-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscriptions block: Layout inconsistent across themes #17590
Comments
I want to add to this that a theme should be able to turn off the customizations or default the styles of the form if we want to give the user the ability to customize it fully. It would be a bad experience if for example a theme design relied on very rounded buttons and this block defaulted to In the case of the block showing both the input and the button on the same line, it seems like the best way to approach this is to have |
Using the Jetpack subscriptions block that is automatically added to a newly created site, what is shown in the block editor is different than what is shown on the published site. See the screenshots below for illustration.
The color and size of the input field is different in the editor and site. The default button color matches other buttons on the site, but there is no hover color or it matches the default color. Noice in the code for the block below, the
The differences in style is observed in Chrome, Firefox, and Safari browsers. See the table below for details about the environment.
|
As mentioned here, the Subscriptions block style is inconsistent across themes. The CSS for the block is inline, which makes it harder for themes to target the block. Ideally the block CSS would be strong enough to ensure the block looked good across all our themes without the theme needing to add any CSS.
Acceptance criteria:
It might make sense to deal with these issues at the same time:
#15227
#15474
The text was updated successfully, but these errors were encountered: