Subscriptions: Remove the shortcode

[scruffian]

The Subscriptions block outputs a shortcode.

Describe the solution you'd like

We should remove this, and output the markup we want for the block directly as suggested by @mtias

Describe alternatives you've considered

Keeping the shortcode means that people who use the shortcode continue to be able to benefit from the additional features we add, but this results in more complex development and doesn't encourage people to move to Gutenburg.

[mmtr]

We created a separated issue for stopping using the simple-payment shortcode as output of the "Pay with PayPal" block: #17246 (fixed by #17256).

I've updated this issue to reflect we only need to handle the Subscriptions block now.

[simison]

Thanks for this! Leaving the shortcode in Simple payments block was one of my biggest regrests. 😅

It came from wish to not add yet another simple payments implementation (alongside widget, classic editor block, and shortcode) but it turned out to be short-sighted and caused more trouble than it was aiming to save time.

[coreymckrill]

Noting that, at present, shortcodes included in the block templates and block template parts of FSE themes are not rendered, and that probably won't change. It seems like that might make this issue a bit more urgent.

[simison]

@kraftbj @jeherve 👋 this issue should be tracked for WP 5.9 readiness.

[jeherve]

this issue should be tracked for WP 5.9 readiness.

Could you clarify a bit what you mean by that? Would 5.9 break rendering of shortcodes in some way?

[jeherve]

ah, I was able to reproduce. For some reason, the shortcode is rendered when used in a footer template, but not in a single post template. I added this issue to the primary issue for WP 5.9 compat.

[simison]

@jeherve is there a way to tell which other blocks output a shortcode? I'm thinking forms and simple payments from memory. Anything else?

[scruffian]

Maybe the contact form too?

[jeherve]

I'm thinking forms and simple payments from memory.

• Simple Payments (Pay with PayPal) used to be powered by a shortcode, but is not anymore since Pay with PayPal block: Save fallback into post content #17256.
• The Form block is a dynamic block, but it does not save a shortcode in the post content so it should not be an issue.

There are no other blocks that should be problematic in that regard as far as I know.

[TimBroddin]

This is fixed with #26947