Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pay With Paypal block: The block should not rely on a shortcode. #17246

Closed
kwight opened this issue Sep 23, 2020 · 0 comments · Fixed by #17256
Closed

Pay With Paypal block: The block should not rely on a shortcode. #17246

kwight opened this issue Sep 23, 2020 · 0 comments · Fixed by #17256
Assignees
Labels
[Block] Pay With Paypal aka Simple Payments [Feature] Pay with PayPal aka Simple Payments [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@kwight
Copy link
Contributor

kwight commented Sep 23, 2020

The Pay With PayPal block saves its content as a shortcode. We should remove its dependence on this old editor abstraction, and save proper HTML markup more consistent with WordPress blocks.

return productId ? <RawHTML>{ `[simple-payment id="${ productId }"]` }</RawHTML> : null;

@jeherve jeherve added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Sep 23, 2020
@mmtr mmtr self-assigned this Sep 25, 2020
@jeherve jeherve added the [Block] Pay With Paypal aka Simple Payments label Feb 12, 2021
@jeherve jeherve added the [Feature] Pay with PayPal aka Simple Payments label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Pay With Paypal aka Simple Payments [Feature] Pay with PayPal aka Simple Payments [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants