Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack: subscription form shortcode not rendered #35

Open
1 of 3 tasks
coreymckrill opened this issue Sep 28, 2021 · 2 comments
Open
1 of 3 tasks

Jetpack: subscription form shortcode not rendered #35

coreymckrill opened this issue Sep 28, 2021 · 2 comments
Labels
Help Wanted Extra attention is needed [Status] Blocked (external) Blocked by something outside our direct control

Comments

@coreymckrill
Copy link
Contributor

coreymckrill commented Sep 28, 2021

The current News site has a subscription form in the sidebar so people can sign up to get email notifications of new News posts. This form is provided by a Jetpack widget. In the new design, the form moves to a footer position, but it's still present on many views. Jetpack has a block for the subscription form, but it's actually just a wrapper around a shortcode. It turns out that shortcodes are not rendered in block templates/parts.

There is an issue in the Jetpack repo to remove the shortcode, but it looks like it hasn't gotten any traction in over a year. Hopefully with FSE looming it will get more attention, but in the mean time, we may need to omit the subscription form or build some kind of temporary server-side block...

  • embed shortcode directly for initial launch
  • Once the Jetpack block no longer relies on the shortcode, switch to that.
  • When we do switch to the block, we'll probably want to disable the default styles that Jetpack adds.
@iandunn iandunn added this to the Initial Launch milestone Oct 14, 2021
@iandunn iandunn added Good First Issue Good for newcomers and removed Good First Issue Good for newcomers labels Oct 14, 2021
@tellyworth tellyworth added the Help Wanted Extra attention is needed label Oct 18, 2021
@iandunn iandunn changed the title Jetpack subscription form Jetpack: subscription form shortcode not rendered Nov 4, 2021
@iandunn
Copy link
Member

iandunn commented Nov 4, 2021

Related WordPress/gutenberg#23626

@iandunn iandunn added the [Status] Blocked (external) Blocked by something outside our direct control label Nov 4, 2021
@iandunn iandunn mentioned this issue Nov 22, 2021
20 tasks
@iandunn iandunn self-assigned this Nov 23, 2021
iandunn added a commit that referenced this issue Nov 24, 2021
Embedding the shortcode directly in the template works for now. Once the Jetpack block no longer relies on the shortcode, we can switch to that.

See #35
@iandunn
Copy link
Member

iandunn commented Nov 24, 2021

dfc9bf6 embeds the shortcode directly in the template, which works for now. Once the Jetpack block no longer relies on the shortcode, we can switch to that.

When we do switch to the block, we'll probably want to disable the default styles that Jetpack adds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed [Status] Blocked (external) Blocked by something outside our direct control
Projects
None yet
Development

No branches or pull requests

3 participants