Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Posts Widget shows Sharing buttons if "show excerpt" option is set #3290

Closed
dereksmart opened this issue Jan 18, 2016 · 11 comments
Closed
Assignees
Labels
[Feature] Extra Sidebar Widgets [Focus] FixTheFlows [Pri] Low [Type] Bug When a feature is broken and / or not performing as intended

Comments

@dereksmart
Copy link
Member

  1. Delete all transients from your site.
  2. Make sure Sharing is active, and that there are buttons to display.
  3. Add a Display Posts widget to any sidebar
  4. Use your own domain as the Blog URL
  5. Make sure "show excerpts" is checked
  6. See that each post displayed in the widget has sharing buttons.

Expected: no sharing buttons should appear in the widget at all.

Note: does not happen when querying posts from a wordpress.com site

@dereksmart dereksmart added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Extra Sidebar Widgets labels Jan 18, 2016
@dereksmart dereksmart added this to the 3.9.1 milestone Jan 18, 2016
@dereksmart
Copy link
Member Author

This is only happening for some sites, and persists even if Sharing is inactive.

For example, try pulling from dereksmart.wpsandbox.me or csonnek.wpsandbox.me

@dereksmart
Copy link
Member Author

this only happens with #3207 JK it happens in master too.

@bisko
Copy link
Contributor

bisko commented Jan 18, 2016

As this was recently in my domain I will check it out :)

@dereksmart
Copy link
Member Author

Update: I can only reproduce this when the remote site has BOTH of these options checked

screen shot 2016-01-18 at 2 43 37 pm

@bisko
Copy link
Contributor

bisko commented Jan 18, 2016

It seems that Sharedaddy adds the share buttons to the excerpts and that is the content that is returned by the remote site.

It is reproduced on both master and #3207 as the code that runs them is the same - just render what is returned in the excerpt.

@jeherve
Copy link
Member

jeherve commented Jan 19, 2016

I'd be tempted to move this to the 3.9 milestone We'll want to avoid adding so many new elements to all the sites that use the Display Posts widget.

@jeherve jeherve modified the milestones: 3.9, 3.9.1 Jan 19, 2016
@jeherve
Copy link
Member

jeherve commented Jan 19, 2016

@bisko let me know this is broken in the current widget as well. Moving this back to 3.9.1.

@jeherve jeherve modified the milestones: 3.9.1, 3.9 Jan 19, 2016
@zinigor zinigor self-assigned this Jan 19, 2016
@kraftbj kraftbj modified the milestones: 3.9.1, 3.9.2 Jan 21, 2016
@jeherve jeherve modified the milestones: 3.9.2, 3.9.3 Mar 1, 2016
@zinigor zinigor modified the milestones: 3.9.3, 3.10 Mar 9, 2016
@jeherve jeherve modified the milestones: 4.0.2, 4.0, 4.0.3 Apr 21, 2016
@jeherve jeherve modified the milestones: 4.0.3, 4.0.4 May 11, 2016
@jeherve jeherve modified the milestones: 4.1, 4.0.4 Jun 3, 2016
@jeherve jeherve modified the milestones: 4.3, 4.1 Jun 17, 2016
@richardmuscat richardmuscat modified the milestones: 4.3, 4.4 Jul 7, 2016
@samhotchkiss samhotchkiss modified the milestones: 4.4, Not Currently Planned Nov 9, 2016
@zinigor
Copy link
Member

zinigor commented Mar 20, 2018

Hmm, I can no longer reproduce with a site that has tries to receive posts from another site with Sharing set to exactly these settings.

@oskosk
Copy link
Contributor

oskosk commented Mar 21, 2018

I couldn't reproduce either. Tried every piece of tip left here (sites and settings details). But testing this was useful to come up with #9107. Closing this one. @dereksmart please reopen if you can still reproduce

@oskosk oskosk closed this as completed Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extra Sidebar Widgets [Focus] FixTheFlows [Pri] Low [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants