Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widgets: WordPress Posts - Add rel=noopener attribute to links in WordPress posts widget if set to open in new window #9107

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Widgets: WordPress Posts - Add rel=noopener attribute to links in WordPress posts widget if set to open in new window #9107

merged 1 commit into from
Mar 21, 2018

Conversation

oskosk
Copy link
Contributor

@oskosk oskosk commented Mar 21, 2018 •
edited
Loading

Changes proposed in this Pull Request:

  • Adds rel="noopener" to post links shown by the WordPress Posts widget if the Open links in new window/tab: setting is active.

Testing instructions:

  • Check this branch.
  • Add a Display WordPress Posts widgets to the sidebar (listed as DisplayWordPress Posts (Jetpack)).
  • Add a WordPress site as Blog URL.
  • Check the box Open links in new window/tab and save the widget.
  • Visit a page on your site that will show the widget.
  • Inspect the links and confirm that the links to the other site posts include the attribute rel="noopener".

Tested in MacOs with:

  • Firefox
  • Opera
  • Safari
  • Chrome

Proposed Changelog Entry

  • Adds rel=noopener attribute to links in the Display WordPress Posts widget if set to open in a new window.

@oskosk oskosk added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Extra Sidebar Widgets [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 21, 2018
@oskosk oskosk added this to the 6.0 milestone Mar 21, 2018
@oskosk oskosk self-assigned this Mar 21, 2018
@oskosk oskosk requested a review from a team as a code owner March 21, 2018 13:30
@oskosk oskosk changed the title Widgets: WordPress posts - Add rel=noopener attribute to links in WordPress posts widget if set to open in new window Widgets: WordPress Posts - Add rel=noopener attribute to links in WordPress posts widget if set to open in new window Mar 21, 2018
@oskosk oskosk requested review from zinigor and dereksmart March 21, 2018 13:32
@oskosk oskosk mentioned this pull request Mar 21, 2018
Closed
jeherve
jeherve approved these changes Mar 21, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. 👍 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 21, 2018
@oskosk
Copy link
Contributor Author

oskosk commented Mar 21, 2018

Thanks @jeherve !

@oskosk oskosk merged commit 70522e5 into master Mar 21, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 21, 2018
@oskosk oskosk deleted the add/noopener-to-display-posts-widget branch March 21, 2018 18:38
oskosk added a commit that referenced this pull request Mar 23, 2018
@oskosk
Add #9107 to changelog
a9ccddf
dereksmart pushed a commit that referenced this pull request Mar 27, 2018
@oskosk @dereksmart
Changelog 6.0: running changelog (#9034)
f54fc7b 
* Changelog 6.0: create base for changelog.

* Add #8938 to changelog

* Add #8962 to changelog

* Add #8974 to changelog

* Add #8975 to changelog

* Add #8978 to changelog

* Add #8867 to changelog

* Add #8937 to changelog

* Add #8961 to changelog

* Add #8855 to changelog

* Add #8944 to changelog

* Add #8973 to changelog

* Add #8977 to changelog

* Add #8979 to changelog

* Add #8980 to changelog

* Add #8982 to changelog

* Add #8983 to changelog

* Add #8984 to changelog

* Add #8986 to changelog

* Add #9005 to changelog

* Add #9010 to changelog

* Add #9012 to changelog

* Add #9021 to changelog

* Add #9022 to changelog

* Add #9056 to changelog

* Add #9061 to changelog

* Add #9079 to changelog

* Add #9080 to changelog

* Add #9088 to changelog

* Add #9096 to changelog

* Add #9097 to changelog

* Add #9100 to changelog

* Add #9107 to changelog

* Add #8969 to changelog

* Add #8993 to changelog

* Add #9003 to changelog

* Add #9031 to changelog

* Add #8945 to changelog

* Add #9052 to changelog

* Add #9058 to changelog

* Add #9066 to changelog

* Add #9076 to changelog

* Add #9053 to changelog

* Add #9108 to changelog

* Add #9135 to changelog

* Add #9148 to changelog

* Add #9125 to changelog

* Add #9137 to changelog

* Added testing instructions for 6.0.

* Added IS testing instructions, huge props to @tiagonoronha.

* Added #8498 to changelog.

* Added #8954 to changelog.

* Added #8985 to changelog.

* add #9027

* add #9112 to changelog

* add #9136 to changelog

* add #9102 to changelog

* add #9093 to changelog

* add #9062 to changelog

* add #9172 to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@zinigor zinigor Awaiting requested review from zinigor

@dereksmart dereksmart Awaiting requested review from dereksmart

Assignees

@oskosk oskosk

Labels
[Feature] Extra Sidebar Widgets [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oskosk @jeherve @matticbot