Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP Dashboard: fix site stats column spacing #8975

Merged
merged 1 commit into from
Mar 7, 2018

Conversation

keoshi
Copy link
Contributor

@keoshi keoshi commented Mar 5, 2018

This PR addresses column spacing styling issues in WP Dashboard > JP Site Stats.

It adds a slight padding-right to the first column of each block.

Before

image

image

After

image

image

Addresses issue in #8678

Proposed changelog entry for your changes:

Addresses column spacing styling issues in WP Dashboard

@keoshi keoshi requested a review from a team as a code owner March 5, 2018 14:29
@keoshi keoshi added Admin Page React-powered dashboard under the Jetpack menu [Pri] Normal [Focus] FixTheFlows [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 5, 2018
@designsimply
Copy link

Where can I find the styling issue? I looked in /wp-admin/admin.php?page=stats and I can see a "Top Posts & Pages" box, but it doesn't look the same as your screenshot.

screen shot 2018-03-05 at mon mar 5 3 58 19 pm
Seen at https://madefortesting.com/wp-admin/admin.php?page=stats using Firefox 58.0.2 on macOS 10.13.3.

@keoshi
Copy link
Contributor Author

keoshi commented Mar 5, 2018

@designsimply This is on the WP Dashboard, so you should be able to see it on https://madefortesting.com/wp-admin/

@designsimply
Copy link

😆 thanks! The "JP Site Stats" part threw me off. I see it now! LGTM

Tested and confirmed the spacing between text blogs in the Site Stats module at the bottom of the WP Dashboard looks good using WordPress 4.9.4 and Jetpack 5.9-beta-17769-837c162-fix_site-stats-columns-spacing.

screen shot 2018-03-05 at mon mar 5 5 18 35 pm
Seen at https://atomic-ant.jurassic.ninja/wp-admin/index.php using Firefox 58.0.2 on macOS 10.13.3.

Copy link
Contributor

@gravityrail gravityrail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gravityrail gravityrail added this to the 6.0 milestone Mar 7, 2018
@gravityrail gravityrail added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 7, 2018
@gravityrail gravityrail merged commit 12ac639 into master Mar 7, 2018
@gravityrail gravityrail deleted the fix/site-stats-columns-spacing branch March 7, 2018 23:32
oskosk added a commit that referenced this pull request Mar 16, 2018
dereksmart pushed a commit that referenced this pull request Mar 27, 2018
* Changelog 6.0: create base for changelog.

* Add #8938 to changelog

* Add #8962 to changelog

* Add #8974 to changelog

* Add #8975 to changelog

* Add #8978 to changelog

* Add #8867 to changelog

* Add #8937 to changelog

* Add #8961 to changelog

* Add #8855 to changelog

* Add #8944 to changelog

* Add #8973 to changelog

* Add #8977 to changelog

* Add #8979 to changelog

* Add #8980 to changelog

* Add #8982 to changelog

* Add #8983 to changelog

* Add #8984 to changelog

* Add #8986 to changelog

* Add #9005 to changelog

* Add #9010 to changelog

* Add #9012 to changelog

* Add #9021 to changelog

* Add #9022 to changelog

* Add #9056 to changelog

* Add #9061 to changelog

* Add #9079 to changelog

* Add #9080 to changelog

* Add #9088 to changelog

* Add #9096 to changelog

* Add #9097 to changelog

* Add #9100 to changelog

* Add #9107 to changelog

* Add #8969 to changelog

* Add #8993 to changelog

* Add #9003 to changelog

* Add #9031 to changelog

* Add #8945 to changelog

* Add #9052 to changelog

* Add #9058 to changelog

* Add #9066 to changelog

* Add #9076 to changelog

* Add #9053 to changelog

* Add #9108 to changelog

* Add #9135 to changelog

* Add #9148 to changelog

* Add #9125 to changelog

* Add #9137 to changelog

* Added testing instructions for 6.0.

* Added IS testing instructions, huge props to @tiagonoronha.

* Added #8498 to changelog.

* Added #8954 to changelog.

* Added #8985 to changelog.

* add #9027

* add #9112 to changelog

* add #9136 to changelog

* add #9102 to changelog

* add #9093 to changelog

* add #9062 to changelog

* add #9172 to changelog
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Focus] FixTheFlows [Pri] Normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants