Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ignored phrase overflow/overlap #8984

Merged
merged 3 commits into from
Mar 16, 2018
Merged

Fix ignored phrase overflow/overlap #8984

merged 3 commits into from
Mar 16, 2018

Conversation

jaswrks
Copy link
Contributor

@jaswrks jaswrks commented Mar 5, 2018 •
edited
Loading

Fixes #8702

Changes proposed:

  • Remove height: property in CSS giving the container an ability to resize based on the number of ignored phrases it contains.

Testing instructions:

  • Checkout this branch and npm run build.
  • Open Jetpack Settings → Writing → Composing → Check your spelling, style, and grammar.
  • Fill in lots of ignored phrases. Enough to consume three or more lines.
  • Observe; the bordered container grows with the number of ignored phrases.

2018-03-05_12-46-14

Before, this was overflowing/overlapping:

screen-shot-2018-01-31-at-12-38-27-pm

Proposed changelog entry:

  • Settings: Fix overflow/overlap when there are many ignored phrases in spelling options.

@jaswrks
Fix ignored phrase overflow/overlap
f0e7f5b 
- Remove `height:` property in CSS.

See: #8702
@jaswrks jaswrks added the [Status] Needs Review This PR is ready for review. label Mar 5, 2018
@jaswrks jaswrks requested a review from a team as a code owner March 5, 2018 21:49
@beaulebens
Copy link
Member

Nice start Jason, already a good improvement. Can we take this one step further and make it so that the lines don't jam up against each other?

I played around with margin a bit and something like this would be good:

screen shot 2018-03-05 at 3 32 34 pm

@beaulebens beaulebens self-requested a review March 5, 2018 22:34
@jaswrks
Copy link
Contributor Author

jaswrks commented Mar 5, 2018 •
edited
Loading

Definitely, yes. Thank you for pointing that out. I fixed. It's much better-er now.

2018-03-05_14-02-09

beaulebens
beaulebens approved these changes Mar 6, 2018
View reviewed changes
Copy link
Member

@beaulebens beaulebens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked in Chrome, Safari and Firefox; looking great everywhere. Nice work!

@brbrr
Copy link
Contributor

brbrr commented Mar 7, 2018

Functionality reviewed by Flow Patrol. I noticed unexpected X button while adding a word in Win10/MSEdge:

msedge - win10 2018-03-07 18-07-46

@gravityrail gravityrail added this to the 6.0 milestone Mar 7, 2018
@gravityrail gravityrail added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Mar 8, 2018
@ghost ghost assigned jaswrks Mar 8, 2018
@jaswrks
Copy link
Contributor Author

jaswrks commented Mar 8, 2018

Great catch! This was caused by the ::ms-clear pseudo element. I fixed this by hiding the ::ms-clear pseudo element and I tested on Win10/MSEdge to confirm.

gravityrail
gravityrail approved these changes Mar 8, 2018
View reviewed changes
Copy link
Contributor

@gravityrail gravityrail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gravityrail gravityrail added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 8, 2018
@keoshi
Copy link
Contributor

keoshi commented Mar 12, 2018

Looks like good to merge — let's do it!

@oskosk oskosk merged commit ad973ee into master Mar 16, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 16, 2018
@oskosk oskosk deleted the fix/ignored-phrases branch March 16, 2018 18:33
oskosk added a commit that referenced this pull request Mar 23, 2018
@oskosk
Add #8984 to changelog
fc29fee
@oskosk oskosk added [Status] Has Changelog and removed [Status] Needs Changelog [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Mar 23, 2018
dereksmart pushed a commit that referenced this pull request Mar 27, 2018
@oskosk @dereksmart
Changelog 6.0: running changelog (#9034)
f54fc7b 
* Changelog 6.0: create base for changelog.

* Add #8938 to changelog

* Add #8962 to changelog

* Add #8974 to changelog

* Add #8975 to changelog

* Add #8978 to changelog

* Add #8867 to changelog

* Add #8937 to changelog

* Add #8961 to changelog

* Add #8855 to changelog

* Add #8944 to changelog

* Add #8973 to changelog

* Add #8977 to changelog

* Add #8979 to changelog

* Add #8980 to changelog

* Add #8982 to changelog

* Add #8983 to changelog

* Add #8984 to changelog

* Add #8986 to changelog

* Add #9005 to changelog

* Add #9010 to changelog

* Add #9012 to changelog

* Add #9021 to changelog

* Add #9022 to changelog

* Add #9056 to changelog

* Add #9061 to changelog

* Add #9079 to changelog

* Add #9080 to changelog

* Add #9088 to changelog

* Add #9096 to changelog

* Add #9097 to changelog

* Add #9100 to changelog

* Add #9107 to changelog

* Add #8969 to changelog

* Add #8993 to changelog

* Add #9003 to changelog

* Add #9031 to changelog

* Add #8945 to changelog

* Add #9052 to changelog

* Add #9058 to changelog

* Add #9066 to changelog

* Add #9076 to changelog

* Add #9053 to changelog

* Add #9108 to changelog

* Add #9135 to changelog

* Add #9148 to changelog

* Add #9125 to changelog

* Add #9137 to changelog

* Added testing instructions for 6.0.

* Added IS testing instructions, huge props to @tiagonoronha.

* Added #8498 to changelog.

* Added #8954 to changelog.

* Added #8985 to changelog.

* add #9027

* add #9112 to changelog

* add #9136 to changelog

* add #9102 to changelog

* add #9093 to changelog

* add #9062 to changelog

* add #9172 to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravityrail gravityrail gravityrail approved these changes

@beaulebens beaulebens beaulebens approved these changes

Assignees

@jaswrks jaswrks

Labels
[Focus] FixTheFlows
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jaswrks @beaulebens @brbrr @keoshi @gravityrail @oskosk @matticbot