Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load Twitter widget using secure connection #9031

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Load Twitter widget using secure connection #9031

merged 1 commit into from
Mar 23, 2018

Conversation

nielslange
Copy link
Member

@nielslange nielslange commented Mar 11, 2018 •
edited by oskosk
Loading

Fixes #8816

Changes proposed in this Pull Request:

  • Loads Twitters widget.js via https instead of http connection

Changelog entry

Shortcodes: We now load Twitters widget.js over https.

@nielslange nielslange requested a review from a team as a code owner March 11, 2018 04:48
@nielslange nielslange added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Feature] Extra Sidebar Widgets labels Mar 11, 2018
jeherve
jeherve approved these changes Mar 12, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 12, 2018
@nielslange
Copy link
Member Author

nielslange commented Mar 19, 2018 •
edited
Loading

Howdy @jeherve!

Despite the fact that I see the following section and could click the button Squash and merge, I assume I'm not authorized doing so, correct? 🤔

screen shot 2018-03-20 at 01 43 30

I think the following paragraph just answered my question:

Ready to Merge (PRs): From here, PRs have been completed, reviewed and tested. From here, the Release Lead (or the Jetpack Lead, if needed) should do a final code review/test run and merge the PR.

Guess I simply have to wait a little bit longer. 😀

@jeherve
Copy link
Member

jeherve commented Mar 20, 2018

Correct :)

@dereksmart dereksmart merged commit e2a0dc6 into Automattic:master Mar 23, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 23, 2018
@nielslange nielslange deleted the fix/8816 branch March 24, 2018 20:30
@oskosk oskosk added this to the 6.0 milestone Mar 26, 2018
oskosk added a commit that referenced this pull request Mar 26, 2018
@oskosk
Add #9031 to changelog
c1d5824
dereksmart pushed a commit that referenced this pull request Mar 27, 2018
@oskosk @dereksmart
Changelog 6.0: running changelog (#9034)
f54fc7b 
* Changelog 6.0: create base for changelog.

* Add #8938 to changelog

* Add #8962 to changelog

* Add #8974 to changelog

* Add #8975 to changelog

* Add #8978 to changelog

* Add #8867 to changelog

* Add #8937 to changelog

* Add #8961 to changelog

* Add #8855 to changelog

* Add #8944 to changelog

* Add #8973 to changelog

* Add #8977 to changelog

* Add #8979 to changelog

* Add #8980 to changelog

* Add #8982 to changelog

* Add #8983 to changelog

* Add #8984 to changelog

* Add #8986 to changelog

* Add #9005 to changelog

* Add #9010 to changelog

* Add #9012 to changelog

* Add #9021 to changelog

* Add #9022 to changelog

* Add #9056 to changelog

* Add #9061 to changelog

* Add #9079 to changelog

* Add #9080 to changelog

* Add #9088 to changelog

* Add #9096 to changelog

* Add #9097 to changelog

* Add #9100 to changelog

* Add #9107 to changelog

* Add #8969 to changelog

* Add #8993 to changelog

* Add #9003 to changelog

* Add #9031 to changelog

* Add #8945 to changelog

* Add #9052 to changelog

* Add #9058 to changelog

* Add #9066 to changelog

* Add #9076 to changelog

* Add #9053 to changelog

* Add #9108 to changelog

* Add #9135 to changelog

* Add #9148 to changelog

* Add #9125 to changelog

* Add #9137 to changelog

* Added testing instructions for 6.0.

* Added IS testing instructions, huge props to @tiagonoronha.

* Added #8498 to changelog.

* Added #8954 to changelog.

* Added #8985 to changelog.

* add #9027

* add #9112 to changelog

* add #9136 to changelog

* add #9102 to changelog

* add #9093 to changelog

* add #9062 to changelog

* add #9172 to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees
No one assigned
Labels
[Feature] Extra Sidebar Widgets [Type] Janitorial
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nielslange @jeherve @oskosk @dereksmart @matticbot