Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Twitter widget using https instead of http: #8816

Closed
garikaib opened this issue Feb 12, 2018 · 1 comment
Closed

Load Twitter widget using https instead of http: #8816

garikaib opened this issue Feb 12, 2018 · 1 comment

Comments

@garikaib
Copy link

Would it be possible to change the line:
/jetpack/modules/shortcodes/tweet.php:140 from:
wp_register_script( 'twitter-widgets', set_url_scheme( 'http://platform.twitter.com/widgets.js' ), array(), JETPACK__VERSION, true );
To use https:
wp_register_script( 'twitter-widgets', set_url_scheme( 'https://platform.twitter.com/widgets.js' ), array(), JETPACK__VERSION, true );

This is my first contribution so I apologise if I am breaking any

@jeherve
Copy link
Member

jeherve commented Feb 12, 2018

That sounds like a good idea. You could actually remove the whole set_url_scheme check and always load the file via HTTPS.

wp_register_script( 'twitter-widgets', 'https://platform.twitter.com/widgets.js', array(), JETPACK__VERSION, true );

Would you like to create a Pull Request with that change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants