Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move like/share metaboxes to right side #8977

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

jaswrks
Copy link
Contributor

@jaswrks jaswrks commented Mar 5, 2018

Fixes #8924

Changes proposed:

Update Like & Sharing metaboxes:

  • Use side context.
  • Use default priority.

Testing instructions:

  • Enable Sharing → Sharing Buttons
    • Confirm metabox shows on right side when adding a new Post.
  • Enable Sharing → Like Buttons
    • Confirm metabox shows on right side when adding a new Post.
  • Also test when one or the other is disabled.

Proposed changelog entry:

  • Likes/Sharing: Move metabox in post editor to the right side for a better fit.

- Use `side` context.
- Use `default` priority.

See: #8924
@jaswrks jaswrks requested a review from a team as a code owner March 5, 2018 15:35
@jaswrks jaswrks added [Status] Ready to Merge Go ahead, you can push that green button! [Status] Needs Review This PR is ready for review. [Focus] FixTheFlows and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 5, 2018
@designsimply
Copy link

Tested and confirmed using https://jurassic.ninja/create?jetpack-beta&nojetpack&branch=fix/like-share-metabox-location and by going to WP Admin > Jetpack > Settings > Sharing and enabling "Like buttons" (sharing buttons were on by default). Confirmed the in the meta box to either "Show likes" or "Show sharing buttons" disappears from the Posts > Add New page if either option is disabled and the whole meta box disappears if both are disabled.

screen shot 2018-03-05 at mon mar 5 3 03 40 pm
Seen at https://convenient-cuban.jurassic.ninja/wp-admin/post-new.php running WordPress 4.9.4 and Jetpack 5.9-beta-17772-9255437-fix_like-share-metabox-location using Firefox 58.0.2 on macOS 10.13.3.

Copy link
Contributor

@gravityrail gravityrail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gravityrail gravityrail merged commit 055f9de into master Mar 5, 2018
@gravityrail gravityrail deleted the fix/like-share-metabox-location branch March 5, 2018 23:02
@oskosk oskosk added this to the 6.0 milestone Mar 9, 2018
oskosk added a commit that referenced this pull request Mar 23, 2018
dereksmart pushed a commit that referenced this pull request Mar 27, 2018
* Changelog 6.0: create base for changelog.

* Add #8938 to changelog

* Add #8962 to changelog

* Add #8974 to changelog

* Add #8975 to changelog

* Add #8978 to changelog

* Add #8867 to changelog

* Add #8937 to changelog

* Add #8961 to changelog

* Add #8855 to changelog

* Add #8944 to changelog

* Add #8973 to changelog

* Add #8977 to changelog

* Add #8979 to changelog

* Add #8980 to changelog

* Add #8982 to changelog

* Add #8983 to changelog

* Add #8984 to changelog

* Add #8986 to changelog

* Add #9005 to changelog

* Add #9010 to changelog

* Add #9012 to changelog

* Add #9021 to changelog

* Add #9022 to changelog

* Add #9056 to changelog

* Add #9061 to changelog

* Add #9079 to changelog

* Add #9080 to changelog

* Add #9088 to changelog

* Add #9096 to changelog

* Add #9097 to changelog

* Add #9100 to changelog

* Add #9107 to changelog

* Add #8969 to changelog

* Add #8993 to changelog

* Add #9003 to changelog

* Add #9031 to changelog

* Add #8945 to changelog

* Add #9052 to changelog

* Add #9058 to changelog

* Add #9066 to changelog

* Add #9076 to changelog

* Add #9053 to changelog

* Add #9108 to changelog

* Add #9135 to changelog

* Add #9148 to changelog

* Add #9125 to changelog

* Add #9137 to changelog

* Added testing instructions for 6.0.

* Added IS testing instructions, huge props to @tiagonoronha.

* Added #8498 to changelog.

* Added #8954 to changelog.

* Added #8985 to changelog.

* add #9027

* add #9112 to changelog

* add #9136 to changelog

* add #9102 to changelog

* add #9093 to changelog

* add #9062 to changelog

* add #9172 to changelog
@mtias
Copy link
Member

mtias commented Apr 5, 2018

This also greatly improves the experience with Gutenberg:

image

@jeherve jeherve added [Feature] Sharing Post sharing, sharing buttons [Feature] Likes labels Apr 5, 2018
@kraftbj kraftbj removed the [Status] Needs Review This PR is ready for review. label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Likes and Shares" metabox better suited to the sidebar
8 participants