Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JITMs: Allow opening in the same window #8982

Merged
merged 1 commit into from
Mar 16, 2018
Merged

JITMs: Allow opening in the same window #8982

merged 1 commit into from
Mar 16, 2018

Conversation

withinboredom
Copy link
Contributor

Fixes #8769

Changes proposed in this Pull Request:

  • Allows specifying that a jitm can be opened in a new window, or the same window.

Testing instructions:

  • Check out this branch and build
  • Check out D10673-code
  • Get a personal plan
  • View the rewind jitm on the dashboard (alternatively update one of the other jitms to use this new rule)
  • Clicking the button should open in same window instead of a new window

@withinboredom withinboredom added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. [Focus] FixTheFlows [Feature] Backup & Scan labels Mar 5, 2018
@withinboredom withinboredom self-assigned this Mar 5, 2018
@withinboredom withinboredom requested a review from a team as a code owner March 5, 2018 19:36
@gravityrail gravityrail changed the title JIITMs: Allow opening in the same window JITMs: Allow opening in the same window Mar 5, 2018
gravityrail
gravityrail approved these changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@gravityrail gravityrail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gravityrail gravityrail added this to the 6.0 milestone Mar 7, 2018
@gravityrail gravityrail added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 7, 2018
oskosk
oskosk approved these changes Mar 16, 2018
View reviewed changes
Copy link
Contributor

@oskosk oskosk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oskosk oskosk merged commit 4899b2d into master Mar 16, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 16, 2018
@oskosk oskosk deleted the add/jitms-new-window branch March 16, 2018 18:20
oskosk added a commit that referenced this pull request Mar 23, 2018
@oskosk
Add #8982 to changelog
008e221
dereksmart pushed a commit that referenced this pull request Mar 27, 2018
@oskosk @dereksmart
Changelog 6.0: running changelog (#9034)
f54fc7b 
* Changelog 6.0: create base for changelog.

* Add #8938 to changelog

* Add #8962 to changelog

* Add #8974 to changelog

* Add #8975 to changelog

* Add #8978 to changelog

* Add #8867 to changelog

* Add #8937 to changelog

* Add #8961 to changelog

* Add #8855 to changelog

* Add #8944 to changelog

* Add #8973 to changelog

* Add #8977 to changelog

* Add #8979 to changelog

* Add #8980 to changelog

* Add #8982 to changelog

* Add #8983 to changelog

* Add #8984 to changelog

* Add #8986 to changelog

* Add #9005 to changelog

* Add #9010 to changelog

* Add #9012 to changelog

* Add #9021 to changelog

* Add #9022 to changelog

* Add #9056 to changelog

* Add #9061 to changelog

* Add #9079 to changelog

* Add #9080 to changelog

* Add #9088 to changelog

* Add #9096 to changelog

* Add #9097 to changelog

* Add #9100 to changelog

* Add #9107 to changelog

* Add #8969 to changelog

* Add #8993 to changelog

* Add #9003 to changelog

* Add #9031 to changelog

* Add #8945 to changelog

* Add #9052 to changelog

* Add #9058 to changelog

* Add #9066 to changelog

* Add #9076 to changelog

* Add #9053 to changelog

* Add #9108 to changelog

* Add #9135 to changelog

* Add #9148 to changelog

* Add #9125 to changelog

* Add #9137 to changelog

* Added testing instructions for 6.0.

* Added IS testing instructions, huge props to @tiagonoronha.

* Added #8498 to changelog.

* Added #8954 to changelog.

* Added #8985 to changelog.

* add #9027

* add #9112 to changelog

* add #9136 to changelog

* add #9102 to changelog

* add #9093 to changelog

* add #9062 to changelog

* add #9172 to changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskosk oskosk oskosk approved these changes

@gravityrail gravityrail gravityrail approved these changes

@bubel bubel Awaiting requested review from bubel

@eliorivero eliorivero Awaiting requested review from eliorivero

@jaswrks jaswrks Awaiting requested review from jaswrks

Assignees

@withinboredom withinboredom

Labels
[Feature] Backup & Scan [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. [Focus] FixTheFlows [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

Activity Log JITM should not open in a new tab
4 participants
@withinboredom @gravityrail @oskosk @matticbot