Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activity Log JITM should not open in a new tab #8769

Closed
MichaelArestad opened this issue Feb 6, 2018 · 3 comments · Fixed by #8982
Closed

Activity Log JITM should not open in a new tab #8769

MichaelArestad opened this issue Feb 6, 2018 · 3 comments · Fixed by #8982
Assignees
@samhotchkiss @withinboredom
Labels
[Feature] Activity Log [Feature] Backup & Scan [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. [Focus] FixTheFlows [Pri] Normal [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Type] Bug When a feature is broken and / or not performing as intended

Comments

@MichaelArestad
Copy link
Contributor

MichaelArestad commented Feb 6, 2018 •
edited by jeherve
Loading

Currently, when clicking on the JITM, it opens in a new tab. Can we change that behavior to not open in a new tab?
@MichaelArestad MichaelArestad added the [Type] Bug When a feature is broken and / or not performing as intended label Feb 6, 2018
@jeherve jeherve added Vault [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. [Feature] Activity Log [Pri] Normal labels Feb 6, 2018
@jeherve jeherve changed the title Activity Log Justine Time message should not open in a new tab Activity Log JITM should not open in a new tab Feb 23, 2018
@beaulebens
Copy link
Member

@MichaelArestad can you remember exactly which message/where this was shown when you encountered this, just to make sure we're getting the right one?

@jeherve jeherve added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Feb 23, 2018
@beaulebens
Copy link
Member

cc @withinboredom

@MichaelArestad
Copy link
Contributor Author

I believe it was the one that says "Switch now" or, if you're in master, "Set up" (I think)

@withinboredom withinboredom mentioned this issue Mar 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samhotchkiss samhotchkiss

@withinboredom withinboredom

Labels
[Feature] Activity Log [Feature] Backup & Scan [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. [Focus] FixTheFlows [Pri] Normal [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

JITMs: Allow opening in the same window Automattic/jetpack
6 participants
@beaulebens @jeherve @samhotchkiss @MichaelArestad @withinboredom @dereksmart