Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SEO/analytics links to avoid redirects #8986

Merged
merged 2 commits into from
Mar 6, 2018
Merged

Conversation

jaswrks
Copy link
Contributor

@jaswrks jaswrks commented Mar 5, 2018

Fixes #8704

Changes proposed:

Update links to avoid unnecessary redirects. The following links redirect to these locations anyway, so this PR is simply linking directly to the ultimate destination.

Testing instructions:

Proposed changelog entry:

  • Settings: Update SEO/analytics links to avoid unnecessary redirects.

@jaswrks jaswrks added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] FixTheFlows labels Mar 5, 2018
@jaswrks jaswrks requested a review from a team as a code owner March 5, 2018 23:37
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM, thanks 👍

Would be great to make it a bit more precise by scrolling to the appropriate sections. I've started Automattic/wp-calypso#23030 to allow this.

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well for me. Would it be possible to add the anchors from Automattic/wp-calypso#23030 already?

@jaswrks
Copy link
Contributor Author

jaswrks commented Mar 6, 2018

I added the #seo and #analytics anchors. 👍

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automattic/wp-calypso#23030 has landed, so we should be good to go.

LGTM 🚢

@tyxla tyxla added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 6, 2018
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Merging!

@jeherve jeherve merged commit 00716b4 into master Mar 6, 2018
@jeherve jeherve deleted the update/seo-links branch March 6, 2018 14:53
@oskosk oskosk added this to the 6.0 milestone Mar 9, 2018
oskosk added a commit that referenced this pull request Mar 23, 2018
dereksmart pushed a commit that referenced this pull request Mar 27, 2018
* Changelog 6.0: create base for changelog.

* Add #8938 to changelog

* Add #8962 to changelog

* Add #8974 to changelog

* Add #8975 to changelog

* Add #8978 to changelog

* Add #8867 to changelog

* Add #8937 to changelog

* Add #8961 to changelog

* Add #8855 to changelog

* Add #8944 to changelog

* Add #8973 to changelog

* Add #8977 to changelog

* Add #8979 to changelog

* Add #8980 to changelog

* Add #8982 to changelog

* Add #8983 to changelog

* Add #8984 to changelog

* Add #8986 to changelog

* Add #9005 to changelog

* Add #9010 to changelog

* Add #9012 to changelog

* Add #9021 to changelog

* Add #9022 to changelog

* Add #9056 to changelog

* Add #9061 to changelog

* Add #9079 to changelog

* Add #9080 to changelog

* Add #9088 to changelog

* Add #9096 to changelog

* Add #9097 to changelog

* Add #9100 to changelog

* Add #9107 to changelog

* Add #8969 to changelog

* Add #8993 to changelog

* Add #9003 to changelog

* Add #9031 to changelog

* Add #8945 to changelog

* Add #9052 to changelog

* Add #9058 to changelog

* Add #9066 to changelog

* Add #9076 to changelog

* Add #9053 to changelog

* Add #9108 to changelog

* Add #9135 to changelog

* Add #9148 to changelog

* Add #9125 to changelog

* Add #9137 to changelog

* Added testing instructions for 6.0.

* Added IS testing instructions, huge props to @tiagonoronha.

* Added #8498 to changelog.

* Added #8954 to changelog.

* Added #8985 to changelog.

* add #9027

* add #9112 to changelog

* add #9136 to changelog

* add #9102 to changelog

* add #9093 to changelog

* add #9062 to changelog

* add #9172 to changelog
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin Page: update links to SEO and GA settings in Calypso
6 participants