Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backups: Update "install and activate" link #8979

Merged
merged 1 commit into from
Mar 7, 2018
Merged

Backups: Update "install and activate" link #8979

merged 1 commit into from
Mar 7, 2018

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Mar 5, 2018 •
edited by oskosk
Loading

Fixes #8487

Changes proposed in this Pull Request:

  • Update the "install and activate" link in the Backups card to be a functional link matching the "Set up" button.

backups

Testing instructions:

  • Get a new Jetpack site with this branch (JN with ?shortlived&jetpack-beta&branch=fix/8487-backup-install-link)
  • Set up the site with a paid plan
  • After checkout but before allowing set up to run, return to the site dashboard.
  • You will see the link on "install and activate" now points to the same URL as the "Set up" button.
  • Click the link and verify that the Backups set up is performed correctly.

Changelog entry

Dashboard: Updated the "install and activate" link in the Backups card to be a functional link matching the "Set up" button.

@sirreal sirreal self-assigned this Mar 5, 2018
@sirreal sirreal requested a review from a team as a code owner March 5, 2018 18:06
@sirreal sirreal changed the title Update link to same as set up Backups: Update link to same as set up Mar 6, 2018
@sirreal sirreal changed the title Backups: Update link to same as set up Backups: Update "install and activate" link Mar 6, 2018
@sirreal sirreal added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Task [Focus] FixTheFlows and removed [Status] In Progress labels Mar 6, 2018
@sirreal sirreal requested a review from a team March 6, 2018 07:43
tyxla
tyxla approved these changes Mar 6, 2018
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests great, I confirm that VaultPress was setup properly 👍

@brbrr
Copy link
Contributor

brbrr commented Mar 7, 2018

Verified by Flow Patrol 😎 👍

@gravityrail gravityrail added this to the 6.0 milestone Mar 7, 2018
@gravityrail gravityrail added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 7, 2018
@gravityrail gravityrail merged commit e2ef82d into master Mar 7, 2018
@gravityrail gravityrail deleted the fix/8487-backup-install-link branch March 7, 2018 23:32
oskosk added a commit that referenced this pull request Mar 23, 2018
@oskosk
Add #8979 to changelog
5cbec89
dereksmart pushed a commit that referenced this pull request Mar 27, 2018
@oskosk @dereksmart
Changelog 6.0: running changelog (#9034)
f54fc7b 
* Changelog 6.0: create base for changelog.

* Add #8938 to changelog

* Add #8962 to changelog

* Add #8974 to changelog

* Add #8975 to changelog

* Add #8978 to changelog

* Add #8867 to changelog

* Add #8937 to changelog

* Add #8961 to changelog

* Add #8855 to changelog

* Add #8944 to changelog

* Add #8973 to changelog

* Add #8977 to changelog

* Add #8979 to changelog

* Add #8980 to changelog

* Add #8982 to changelog

* Add #8983 to changelog

* Add #8984 to changelog

* Add #8986 to changelog

* Add #9005 to changelog

* Add #9010 to changelog

* Add #9012 to changelog

* Add #9021 to changelog

* Add #9022 to changelog

* Add #9056 to changelog

* Add #9061 to changelog

* Add #9079 to changelog

* Add #9080 to changelog

* Add #9088 to changelog

* Add #9096 to changelog

* Add #9097 to changelog

* Add #9100 to changelog

* Add #9107 to changelog

* Add #8969 to changelog

* Add #8993 to changelog

* Add #9003 to changelog

* Add #9031 to changelog

* Add #8945 to changelog

* Add #9052 to changelog

* Add #9058 to changelog

* Add #9066 to changelog

* Add #9076 to changelog

* Add #9053 to changelog

* Add #9108 to changelog

* Add #9135 to changelog

* Add #9148 to changelog

* Add #9125 to changelog

* Add #9137 to changelog

* Added testing instructions for 6.0.

* Added IS testing instructions, huge props to @tiagonoronha.

* Added #8498 to changelog.

* Added #8954 to changelog.

* Added #8985 to changelog.

* add #9027

* add #9112 to changelog

* add #9136 to changelog

* add #9102 to changelog

* add #9093 to changelog

* add #9062 to changelog

* add #9172 to changelog
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

Assignees

@sirreal sirreal

Labels
[Focus] FixTheFlows [Type] Task
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

Jetpack: Backup link
7 participants
@sirreal @brbrr @tyxla @gravityrail @kraftbj @oskosk @matticbot