VaultPress: if Rewind is enabled, remove its entry in sidebar and hide its notice #9056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vate it, hide the notice that requested attention, and show a notification s.
eliorivero
added
[Type] Bug
georgestephanis
requested changes
Mar 19, 2018
3rd-party/vaultpress.php
Outdated
| function jetpack_vaultpress_rewind_check() { | ||
| if ( Jetpack::is_active() && | ||
| Jetpack::is_plugin_active( 'vaultpress/vaultpress.php' ) && | ||
| Jetpack::is_rewind_enabled() | ||
| ) { | ||
| remove_submenu_page( 'jetpack', 'vaultpress' ); | ||
|
|
||
| deactivate_plugins( 'vaultpress/vaultpress.php' ); |
There was a problem hiding this comment.
Moving this to here is probably a bad idea.
We had intentionally left it in the notice function, as there may be pages that admin_init runs on (such as admin_ajax) that would otherwise deactivate the plugin without the notification explaining ever being shown.
There was a problem hiding this comment.
Cool, I'll make the change and will add a comment explaining why it's there.
…n the admin_notices hook.
georgestephanis
approved these changes
Mar 19, 2018
georgestephanis
added
[Status] Ready to Merge
ghost
removed
the
[Status] Ready to Merge
dereksmart
pushed a commit
that referenced
this pull request
Mar 27, 2018
* Changelog 6.0: create base for changelog. * Add #8938 to changelog * Add #8962 to changelog * Add #8974 to changelog * Add #8975 to changelog * Add #8978 to changelog * Add #8867 to changelog * Add #8937 to changelog * Add #8961 to changelog * Add #8855 to changelog * Add #8944 to changelog * Add #8973 to changelog * Add #8977 to changelog * Add #8979 to changelog * Add #8980 to changelog * Add #8982 to changelog * Add #8983 to changelog * Add #8984 to changelog * Add #8986 to changelog * Add #9005 to changelog * Add #9010 to changelog * Add #9012 to changelog * Add #9021 to changelog * Add #9022 to changelog * Add #9056 to changelog * Add #9061 to changelog * Add #9079 to changelog * Add #9080 to changelog * Add #9088 to changelog * Add #9096 to changelog * Add #9097 to changelog * Add #9100 to changelog * Add #9107 to changelog * Add #8969 to changelog * Add #8993 to changelog * Add #9003 to changelog * Add #9031 to changelog * Add #8945 to changelog * Add #9052 to changelog * Add #9058 to changelog * Add #9066 to changelog * Add #9076 to changelog * Add #9053 to changelog * Add #9108 to changelog * Add #9135 to changelog * Add #9148 to changelog * Add #9125 to changelog * Add #9137 to changelog * Added testing instructions for 6.0. * Added IS testing instructions, huge props to @tiagonoronha. * Added #8498 to changelog. * Added #8954 to changelog. * Added #8985 to changelog. * add #9027 * add #9112 to changelog * add #9136 to changelog * add #9102 to changelog * add #9093 to changelog * add #9062 to changelog * add #9172 to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8691
This PR fixes issues with VaultPress deactivation driven by Jetpack when Rewind is active:
Proposed changes
The Jetpack menu was previously still showing the VaultPress submenu and clicking it lead to a blank page. This is now fixed here.
The notice saying "VaultPress needs your attention!" was still shown before, but it's now hidden. It was complex to remove it since it wasn't possible to remove the actions hooked to
user_admin_noticesandadmin_notices. To overcome this, a<style>tag was added with a rule to hide the notice.Updated PHPDocs.
Testing instructions:
Proposed changelog entry for your changes:
VaultPress: menu item going nowhere is now suppressed.