-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External Media: remove duplicate "generate with AI" #39934
Comments
This was introduced in #38123. It does seem like we could remove the extra entry point indeed. cc'ing @Automattic/jetpack-agora on this. |
This additional entry point was intentional, to get more visibility for the AI tool. The rationale is that we already have separate entry points for upload, add image via link, and select image from a list of services, generating with AI would be an additional category - conceptually. |
Insert from URL is from Core. I'd prefer we don't touch the Core items when possible and instead consolidate duplicate options currently in the interface from JP! |
I can only speak to what I think is best for Jetpack users and revenue, so I recommend leaving the entry point. Not sure if we have any processes around what to prioritize and who makes these decisions. |
Thank you, @pablohoneyhoney, for the thorough feedback! We already have a planned task to improve the AI image generation UI, and all your notes are super helpful. @keoshi and I reviewed all the points, noted the problems, and added them to the issue, which we will work on in the next few weeks.
100% Agree! For the Jetpack AI numbers, @vianasw do you have them? Or maybe someone on @Automattic/jetpack-agora? Let's make sure we are aware on the impact on our metrics before removing an entry point. |
I'm not able to pull these numbers as we don't do tracking for this on WordPress Core. The best option is to pull tracking from Jetpack and/or WordPress.com.
I'm a bit surprised we're taking up precious real estate with duplicated options added onto the Image block. It makes sense that if you add an option for the same thing in more places, you'll get more clicks, especially for an option as visible as being in the placeholder. What about the experience for the user though? If we are offering the same thing twice, how is the user to make sense of that? As it stands, I'd expect them to do different things. To make things more complex, we show the options to generate with AI when you choose "select image" but not when you choose "add image". All of these add up to create friction. |
Hey, thanks for opening this issue. For me, it's a visual challenge. I don't understand how we're okay with shipping something that looks like this:
If we had a solid design that looked great, and handled every use case, it would be much harder to refute the numbers. But as is, this is trash pickup territory. If you need to make change to the Image setup state in order to better accomodate this duplication, feel free to open core pull requests, you have a two week window before the next plugin release. |
@annezazu Curious what makes this real estate precious, as it seems we have plenty of space in the placeholder? In my perspective it's about two things: Surfaced button in placeholderAs @grbicsanja mentioned above, bubbling up the “Generate with AI” option is a nice way to immediately surface the value Jetpack provides. If we consider the end-to-end experience, starting with WordPress and adding Jetpack afterwards, it becomes clear that AI is part of the added value in Jetpack tooling. The metrics above indicate this is the preferred way of interacting with it and it makes sense considering it's prominent visibility. Removing this option would therefore get rid of an important entry point. Duplicated option in the dropdownWhat we see in the image block as a duplicated option, actually serves a much broader goal of aligning all media manipulation instances. This dropdown shows up in multiple places as a unified set of actions, so it would be good to keep the options the same. Even if it causes duplication in some blocks. That seems like a fair UI compromise in service of honorable goals: discovery, value.
We'll take care of this as soon as possible. |
See #39934 Let's change the overall styles of the 2 buttons ("Select Image" and "Generate with AI"): - the buttons should be 40px high, like in Core. See WordPress/gutenberg#46741 - the buttons should use the secondary style variant by default, to match the "Insert from URL" button. - the buttons should take the full width of the placeholder on mobile devices.
See #39934 Let's change the overall styles of the 2 buttons ("Select Image" and "Generate with AI"): - the buttons should be 40px high, like in Core. See WordPress/gutenberg#46741 - the buttons should use the secondary style variant by default, to match the "Insert from URL" button. - the buttons should take the full width of the placeholder on mobile devices.
See #39934 Let's change the overall styles of the 2 buttons ("Select Image" and "Generate with AI"): - the buttons should be 40px high, like in Core. See WordPress/gutenberg#46741 - the buttons should use the secondary style variant by default, to match the "Insert from URL" button. - the buttons should take the full width of the placeholder on mobile devices.
I believe this was mentioned in some of these issues, but what about making “Insert from URL” part of the dropdown of “Select an image”. That way, other media blocks could benefit from this extra option being offered universally. Again, given the number above it doesn't seem like a great idea to remove an important entry point. Sidenote: it would be great to think about an affordance to make it clear the “Select image” button contains more options. Not sure if the chevron has been used in conjunction with text. Perhaps there's a better pattern? |
I definitely think there's a design exploration that involves reducing the URL option substantially. The main challenge here is that with no plugins active, the button is called "Media library", and opens it directly: For people without extensions, it's unclear if the consolidation is worth the extra click. Stepping back, though, the Image placeholder is an "onboarding opportunity", and despite having had many iterations already, it's fully open to being revisited, refined yet again, should any of you have cycles. |
* External Media / AI Image Generator: update button style See #39934 Let's change the overall styles of the 2 buttons ("Select Image" and "Generate with AI"): - the buttons should be 40px high, like in Core. See WordPress/gutenberg#46741 - the buttons should use the secondary style variant by default, to match the "Insert from URL" button. - the buttons should take the full width of the placeholder on mobile devices. * Ensure the buttons look good in narrow parent blocks See #39985 (comment) * Simplify styling of the main wrapper The wrapper itself is still necessary unfortunately. Co-authored-by: Filipe Varela <keoshi@keoshi.com> Co-authored-by: jasmussen <joen@git.wordpress.org> * Add logic to change button size based on wp & Gutenberg versions The other buttons in the Image block were changed in this PR: WordPress/gutenberg#65361 This was released with Gutenberg 19.4, and will be included in WP version 6.7. Let's consequently set our own buttons to match. --------- Co-authored-by: Filipe Varela <keoshi@keoshi.com> Co-authored-by: jasmussen <joen@git.wordpress.org>
Currently, there are two "Generate with AI" options added into the Image block when using Jetpack:
Similar to #39933, this adds a bit of clutter to the experience as is. Curious what design thinks or why it's best to have this option twice! As is, I'd be keen to see it only in the dropdown when selecting an image as that ensures consistency across interacting with images, including setting a featured image or using a tiled gallery.
The text was updated successfully, but these errors were encountered: