Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sitemaps: Add thumbnails to video sitemaps #11449

Merged
merged 5 commits into from
Mar 12, 2019
Merged

Sitemaps: Add thumbnails to video sitemaps #11449

merged 5 commits into from
Mar 12, 2019

Conversation

aheckler
Copy link
Member

@aheckler aheckler commented Mar 1, 2019 •
edited
Loading

Uses thumbnails from processed VideoPress videos where possible, otherwise falls back to a (filterable) blank image. This will avoid Google Search Console (fka Google Webmaster Tools) from complaining about invalid URLs in video sitemaps.

Fixes #9539.

Testing instructions:

  1. Start with a properly connected, self-hosted site with a Premium or Professional plan.
  2. Enable Jetpack's video hosting feature under Jetpack > Settings > Performance > Media section.
  3. Upload a video to the site via wordpress.com/media.
  4. Wait for VideoPress to finish processing the video.
  5. Rebuild sitemaps with wp jetpack sitemap rebuild --purge.
  6. View the view sitemap at www.example.com/video-sitemap-1.xml.

Videos processed with VideoPress will show an actual thumbnail. Videos not processed with VideoPress will have a blank image as the thumbnail, which is better than nothing.

screen shot 2019-03-01 at 7 04 58 am

Proposed changelog entry for your changes:

Added thumbnails to video sitemaps as required by Google Search Console

@aheckler
Add thumbnails to video sitemap
bf62166 
Fixes #9539.

Uses thumbnails from processed VideoPress videos where possible, otherwise falls back to a blank image. This will avoid Google Search Console (aka Google Webmaster Tools) from complaining about invalid URLs in video sitemaps.
@aheckler aheckler added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] VideoPress A feature to help you upload and insert videos on your site. [Feature] Sitemaps labels Mar 1, 2019
@aheckler aheckler self-assigned this Mar 1, 2019
@aheckler aheckler requested a review from a team March 1, 2019 12:10
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello aheckler! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D25007-code before merging this PR. Thank you!

@jetpackbot
Copy link
Collaborator

jetpackbot commented Mar 1, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 2, 2019.
Scheduled code freeze: March 26, 2019

Generated by 🚫 dangerJS against 831d81e

@aheckler aheckler added the [Status] Needs Review This PR is ready for review. label Mar 1, 2019
@matticbot
Copy link
Contributor

aheckler, Your synced wpcom patch D25007-code has been updated.

@matticbot
Copy link
Contributor

aheckler, Your synced wpcom patch D25007-code has been updated.

@matticbot
Copy link
Contributor

aheckler, Your synced wpcom patch D25007-code has been updated.

@jeherve jeherve added this to the 7.2 milestone Mar 4, 2019
@matticbot
Copy link
Contributor

aheckler, Your synced wpcom patch D25007-code has been updated.

@kraftbj
Copy link
Contributor

kraftbj commented Mar 8, 2019

Works as advertised for me, but I need to test it again not on JN. The way JN defines the URL breaks sitemaps, which is outside the scope of this PR, but want to see it live. Also would need to run a non-JN sitemap through a validator to confirm.

@kraftbj kraftbj added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Mar 8, 2019
@kraftbj
Copy link
Contributor

kraftbj commented Mar 8, 2019

Tested it and looked good. Images populated as expected and passed validation. Pending the question about the default image, 🚢

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Mar 12, 2019
@kraftbj kraftbj merged commit 6cf62b5 into master Mar 12, 2019
@kraftbj kraftbj deleted the enhance/9539 branch March 12, 2019 14:04
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 12, 2019
@kraftbj
Copy link
Contributor

kraftbj commented Mar 12, 2019

r188792-wpcom

kraftbj added a commit that referenced this pull request Mar 25, 2019
@kraftbj
Add CL and testing instructions for #11449
de9049a
kraftbj added a commit that referenced this pull request Mar 27, 2019
@kraftbj
Add initial 7.2 changelog to master (#11690)
2227bfd 
* Initial Changelog for 7.2

* Testing list: add mention of IE11 testing

* Initial Changelog for 7.2

* Testing list: add mention of IE11 testing

* Add CL for #11224

* Add CL for #11426

* Add CL for #11442

* Add testing instructions for #11224

* Add CL for #11451

* Reclassify CL item

* Add testing instructions for #11451

* Add CL for #11486

* Add CL for #11418

* Add CL for #11524

* Add CL and testing instructions for #11449

* Add CL for #11460

* Add CL for #11520 and #11582

* Add CL for #11531

* Add CL #11644

* Add testing instructions for #11644

* Add testing instructions for #11644

* Add CL for #11618

* Uniform changelog lines

* CL #11679

* CL #11661

* CL #11654

* CL #11645

* CL #11643

* CL #11636

* CL #11635 and for other PHPCS commits

* CL #11627

* CL #11626

* CL #11598

* CL #11596

* Remove nested items for shortcopy. I don't believe the detailed list is helpful

* CL #11570

* CL #11569

* CL #11560

* CL #11558

* CL #11555

* CL #6704

* CL #11298

* CL #11324

* CL #11443

* CL #11484

* CL #11516

* CL #11529

* Expand Ads block enhancement CL item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

Assignees

@aheckler aheckler

Labels
[Feature] Sitemaps [Feature] VideoPress A feature to help you upload and insert videos on your site. [Status] Tested on WP.com Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
5 participants
@aheckler @matticbot @jetpackbot @kraftbj @jeherve