-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions: Restore declared script dependencies #11968
Conversation
This is an automated check which relies on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and tested that editor and view side still work. 👍
Caution: This PR has changes that must be merged to WordPress.com |
@sirreal When you merge this, could you handle the wp.com merge? D26652-code now contains a few different PRs worth of class-jetpack-gutenberg.php changes (including D26525-code from #11591). Marking the wpcom test as passed since it fails as this partially reverts an uncommitted WP.com side change. |
I've created D26666-code to handle the full sync. This includes a change to the way dependencies are read, so I'll need to include an extensions build as well. |
With a part of our build tooling supplying WordPress script dependencies (#11591), we removed the ability to declare script dependencies explicitly.
There are cases that are not yet covered by the tooling —https://github.com/Automattic/jetpack/pull/9802/files#r272845657. Restore the ability to declare script dependencies.
Testing instructions:
thickbox
dependency.