Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions: Restore declared script dependencies #11968

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Apr 8, 2019

With a part of our build tooling supplying WordPress script dependencies (#11591), we removed the ability to declare script dependencies explicitly.

There are cases that are not yet covered by the tooling —https://github.com/Automattic/jetpack/pull/9802/files#r272845657. Restore the ability to declare script dependencies.

Testing instructions:

  • No regressions, scripts continue to include automatic dependencies, polyfill is always included.
  • Membership Block #9802 will be able to declare thickbox dependency.

@sirreal sirreal added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Apr 8, 2019
@sirreal sirreal self-assigned this Apr 8, 2019
@sirreal sirreal requested review from artpi and a team April 8, 2019 13:54
@sirreal sirreal mentioned this pull request Apr 8, 2019
@jetpackbot
Copy link

Warnings
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 9a3e690

Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested that editor and view side still work. 👍

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello sirreal! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D26652-code before merging this PR. Thank you!

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Apr 8, 2019
@kraftbj
Copy link
Contributor

kraftbj commented Apr 8, 2019

@sirreal When you merge this, could you handle the wp.com merge? D26652-code now contains a few different PRs worth of class-jetpack-gutenberg.php changes (including D26525-code from #11591).

Marking the wpcom test as passed since it fails as this partially reverts an uncommitted WP.com side change.

@sirreal sirreal merged commit a18ed0b into master Apr 9, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 9, 2019
@sirreal sirreal deleted the update/restore-declared-script-deps branch April 9, 2019 06:01
@sirreal
Copy link
Member Author

sirreal commented Apr 9, 2019

I've created D26666-code to handle the full sync. This includes a change to the way dependencies are read, so I'll need to include an extensions build as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants