Memberships: Product creation fail message

[artpi]

For some reasons, product creation fails for certain sites. #9802 (review)
The error message is terrible. We have captured extensive logs on wpcom side, but error is not returned properly.

This change is only executed on WPCOM side and its already merged there.
This PR syncs it.
No testing necessary.

[jetpackbot]

	Warnings
⚠️	"Testing instructions" are missing for this PR. Please add some
⚠️	"Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against b1436c2

[artpi]

@kraftbj I don't think this needs cherry-pick. This code here is never executed in Jetpack. I am getting it into JP for Fusion's sake, but it makes no difference for the users and their sites. Its merged to wpcom where it makes sense.

[jeherve]

While it works to avoid the first error, I think we would also need to update the Membership block itself to support use-cases when no product can be created. Right now, when running into this error you end up getting the following in the block editor:

Warning: Each child in an array or iterator should have a unique "key" prop.
Check the render method of `MembershipsButtonEdit`.

This seems to happen because this.state.products is an empty array.

[kraftbj]

@kraftbj I don't think this needs cherry-pick. This code here is never executed in Jetpack. I am getting it into JP for Fusion's sake, but it makes no difference for the users and their sites. Its merged to wpcom where it makes sense.

Understood it isn't needed, but I do like to keep any code related to a new feature in Jetpack going out at the same time, even if it doesn't run. If it is a bug fix for something unreleased that either fixes something seen or has no liability (in this case), rather cherry-pick than not.

Cherry-picking is not something we expect or want you, as the originating developer, to do. It's a quick thing on my side as I'm working through the beta week.

[artpi]

@jeherve I added b1436c2 which passes the error causing it to display:

[jeherve]

The error message isn't especially helpful since it does not tell you what to do next, but it's better than the current version in master.

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello artpi! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D27845-code before merging this PR. Thank you!

[artpi]

The error message isn't especially helpful since it does not tell you what to do next

That is because I honestly don't know why this error occurs on your site :D
Once we solve core issue, the message should not even be necessary.

[artpi]

D27845-code is deployed.

[jeherve]

@artpi Let's take that opportunity to bring the file in sync to solve those Fusion issues. See D27848-code.

[artpi]

@jeherve Fusion PR is waiting patiently for when this right here lands.
See D27731-code

[jeherve]

Cherry-picked to branch-7.3 in 32f1e95