Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Update method for inserting JavaScript - Removed fallback / workaround for themes without wp_footer #13182

Merged
merged 2 commits into from
Aug 16, 2019
Merged

Stats: Update method for inserting JavaScript - Removed fallback / workaround for themes without wp_footer #13182

merged 2 commits into from
Aug 16, 2019

Commits on Aug 5, 2019

  1. Removed fallback / workaround for themes without wp_footer 

    After discussion on Github issue "Stats: Update method for inserting JavaScript Automattic#3763" it was considered that it was a safe assumption to make that a theme would always have a `wp_footer` action.

This update removes code which was used to provide a fallback / workaround in the case of themes which did not contain a `wp_footer` action.

The workaround consisted of setting a global variable `$rendered_stats_footer` which would get set to true if the `wp_footer` call was successful, if not successful then the WP Stats JS code would get set via a `wp_head` action instead.
    @rickcurran
    rickcurran committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    c2cd2ae View commit details
    Browse the repository at this point in the history

  2. Fixed incorrect use of spaces instead of tabs 

    Fixed incorrect use of spaces instead of tabs
    @rickcurran
    rickcurran committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    ca0f3f7 View commit details
    Browse the repository at this point in the history