Premium blocks: Add plan param to redirect URL - take 2 - simple sites

[chriskmnds]

Fixes #13003 (partially)

Related: Automattic/wp-calypso#35697

Changes proposed in this Pull Request:

Handles adding the plan_upgraded=1 query param to simple site urls passed from the "upgrade nudge" in the redirect_to param. We (@simison primarily) spotted that in #13218 we were only handling jetpack self-hosted sites. Effectively this will be passed on redirection once a plan has been upgraded successfully after clicking on the "upgrade nudge".

---

The result after these changes is the user landing on the calypso block editor with a url of the form https://wordpress.com/block-editor/post/chriskmnds.wordpress.com/3?plan_upgraded=1

---

Is this a new feature or does it add/remove features to an existing part of Jetpack?

• It adds the foundation for showing a notification when the redirection happens after clicking an upgrade nudge.

Testing instructions:

• Apply the underlying diff to your sandbox.
• Load a non-premium non-jetpack wpcom site that is linked to your sandbox.
• Open a post and add the "simple payments" block.
• Click on the upgrade nudge and purchase a premium plan to enable simple payments.
• On redirection back to the editor, confirm that the URL contains the parameter &plan_upgraded=1.

Proposed changelog entry for your changes:

• Doesn't need one I think?

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello chriskmnds! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D31758-code before merging this PR. Thank you!

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: September 3, 2019.
Scheduled code freeze: August 27, 2019

Generated by 🚫 dangerJS against 0bfb7ba

[sirreal]

I am sent back to the editor with plan_upgraded=1 after purchase

[ockham]

Just noting that we'll also need to update the frontend nudge (both for Simple Sites, and Jetpack) 😬
(fine to do in a separate PR)

jetpack/_inc/lib/components.php

Lines 90 to 98 in d40347a

	$redirect_to = ( defined( 'IS_WPCOM' ) && IS_WPCOM )
	? '/' . implode( '/', array_filter( array( $post_type_editor_route_prefix, $post_type, $site_slug, $post_id ) ) )
	: add_query_arg(
	array(
	'action' => 'edit',
	'post' => $post_id,
	),
	admin_url( 'post.php' )
	);

[chriskmnds]

Just noting that we'll also need to update the frontend nudge (both for Simple Sites, and Jetpack) 😬

Can you tell me a little more about that? What is it and why are you referring to it explicitly as "frontend nudge"? 😀

[simison]

"Frontend nudge" in this case means when the block is added and saved to the content, on the public-facing website there's a nudge visible only to admins. You can test it with simple payments block currently.

[ockham]

What Mikael said :) "Frontend" as in HTML rendered for site visitors (vs "backend" as in wp-admin). We're using some magic to render our React component to some static HTML (that we actually turn into PHP to include translation calls, such as __()) -- see #13070. However, in order to replicate some of the logic (e.g. needed for the redirect targets), we have to provide some data through PHP.

In this case, the required change should be fairly straight-forward 🤞

[simison]

The "Frontend" URLs update would be fine to do in separate PR btw!