Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak connect prompt margins on mobile devices #13311

Merged
merged 4 commits into from
Aug 23, 2019
Merged

Tweak connect prompt margins on mobile devices #13311

merged 4 commits into from
Aug 23, 2019

Conversation

gravityrail
Copy link
Contributor

In testing, @roccotripaldi and @jeffgolenski noticed a few extra-chunky margins in our connect prompts that made things feel weird on phones.

This tunes up the margins a bit.

Plugins Prompt Before:

goldsounds ngrok io_wp-admin_plugins php_activate=true plugin_status=all paged=1 s=(Pixel 2 XL)

Plugins Prompt After:

goldsounds ngrok io_wp-admin_plugins php_plugin_status=all paged=1 s(Pixel 2 XL)

Dashboard Prompt Before:

goldsounds ngrok io_wp-admin_admin php_page=jetpack(Pixel 2 XL)

Dashboard Prompt After:

goldsounds ngrok io_wp-admin_admin php_page=jetpack(Pixel 2 XL) (3)

@gravityrail gravityrail requested a review from a team August 23, 2019 19:07
@gravityrail gravityrail added the [Status] Needs Design Review Design has been added. Needs a review! label Aug 23, 2019
@gravityrail gravityrail self-assigned this Aug 23, 2019
@jetpackbot
Copy link
Collaborator

jetpackbot commented Aug 23, 2019 •
edited
Loading

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against b892ecc

roccotripaldi
roccotripaldi previously requested changes Aug 23, 2019
View reviewed changes
Copy link
Member

@roccotripaldi roccotripaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I think we can omit the jp-search files from this diff

@gravityrail
Copy link
Contributor Author

@roccotripaldi fixed, got rid of those files

@gravityrail gravityrail merged commit 878aab0 into master Aug 23, 2019
@gravityrail gravityrail deleted the fix/mobile-connect-flow-styles branch August 23, 2019 21:58
@jeherve jeherve added the Connect Flow Connection banners, buttons, ... label Aug 26, 2019
@jeherve jeherve added this to the 7.7 milestone Aug 26, 2019
jeherve added a commit that referenced this pull request Aug 26, 2019
@jeherve
Changelog: add #13311
05e20fd
@jeffgolenski
Copy link
Member

👍 Thanks for the design focus here!

jeherve added a commit that referenced this pull request Aug 27, 2019
@jeherve
7.7 changelog: initial set of changes (#13190)
190301b 
* 7.7 changelog: initial set of changes

* Changelog: add #13154

* Changelog: add #13134

* Changelog: add #12699 and many others

* Changelog: add #13127

* Changelog: add #13167

* Changelog: add #13225

* Changelog: add #13179

* Changelog: add #13173

* Changelog: add #13232

* Changelog: add #13137

* Changelog: add #13172

* Changelog: add #13182

* Changelog: add #13200

* Changelog: add #13244

* Changelog: add #13267

* Changelog: add #13204

* changelog: add #13205

* Changelog: add #13183

* Changelog: add #13278

* Changelog: add #13162

* Changelog: add #13268

* Changelog: add #13286

* Changelog: add #13273

* Changelog: add #12474

* Changelog: add #13085

* Changelog: add #13266

* Changelog: add #13306

* Changelog: add #13311

* Changelog: add #13302

* Changelog: add #13196

* Changelog: add #12733

* Changelog: add #13261

* Changelog: add #13322

* Changelog: add #13333

* Changelog: add #13335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lezama lezama lezama approved these changes

@roccotripaldi roccotripaldi roccotripaldi left review comments

@jeffgolenski jeffgolenski Awaiting requested review from jeffgolenski

Assignees

@gravityrail gravityrail

Labels
Connect Flow Connection banners, buttons, ... [Status] Needs Design Review Design has been added. Needs a review!
Projects
None yet
Milestone
7.7
Development

Successfully merging this pull request may close these issues.
7 participants
@gravityrail @jetpackbot @jeffgolenski @lezama @roccotripaldi @jeherve @matticbot