Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Title attribute to the iframe for Archive.org book embed #13451

Merged
merged 3 commits into from
Sep 19, 2019
Merged

Added Title attribute to the iframe for Archive.org book embed #13451

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e95809
Added Title attribute to the iframe for Archive.org book embed
rickcurran Sep 9, 2019
bf2acf7
Updated test for Archive-book shortcode to include the new `title` at…
rickcurran Sep 16, 2019
8dc77e2
Merge branch 'master' into include-title-attribute-on-iframe-to-meet-…
jeherve Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/shortcodes/archiveorg-book.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,9 @@ function jetpack_archiveorg_book_shortcode( $atts ) {

$url = esc_url( set_url_scheme( "http://archive.org/stream/{$id}?ui=embed#mode/1up" ) );

$html = "<div class='embed-archiveorg-book' style='text-align:center;'><iframe src='$url' width='$width' height='$height' style='border:0;' webkitallowfullscreen='true' mozallowfullscreen='true' allowfullscreen></iframe></div>";
$title = esc_html__( 'Archive.org Book', 'jetpack' );

$html = "<div class='embed-archiveorg-book' style='text-align:center;'><iframe title='$title' src='$url' width='$width' height='$height' style='border:0;' webkitallowfullscreen='true' mozallowfullscreen='true' allowfullscreen></iframe></div>";
return $html;
}

Expand Down