Store "Assumed site creation date" in transient

[dereksmart]

Changes proposed in this Pull Request:

This PR does two things:

1. Removes the duplicate Jetpack::get_assumed_site_creation_date() in the main Jetpack class, and replaces it with the package method.
2. Caches the date in a transient.

This method is called on every Jetpack Admin page load, because it's used in the build_connect_url() method that is passed into the initial state. We don't even need it in most cases (like if the user is already connected) - unless I guess if the user wants to disconnect/reconnect without a page load, so it could be further improved to not pass at all in that case, but not worth the extra complication.

I'm not sure if there was a reason for not caching, but it seems like something that only needs to be checked and stored once.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

• Slightly improves

Testing instructions:

You can check with a plugin such as Query monitor:

• Before applying patch, load the Jetpack admin page and note the number of queries.
• After applying the patch, load the admin page. The first page load may not see signs of improvement, but subsequent page loads will be making fewer queries.

Proposed changelog entry for your changes:

• Slight performance increase in the admin area? Maybe not worth mentioning?

[jetpackbot]

	Warnings
⚠️	pre-commit hook was skipped for one or more commits

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against ff2d21e

[tyxla]

This is looking good, thank you for the improvement!

I'm only hesitant to directly remove a method vs deprecating it for at least a couple of versions.

Should be good after updating that. Also, left some questions for your consideration.

[tyxla]

Could we use the existing connection manager so we don't instantiate a new connection manager if there's one already?

Suggested change

	'site_created' => $connection->get_assumed_site_creation_date(),
	'site_created' => self::connection()->get_assumed_site_creation_date(),

[tyxla]

LGTM, just left a small suggestion for fixing the deprecated notice call.

Feel free to 🚢 once it's solved 👍

[tyxla]

LGTM, thanks again 🚢

[jeherve]

Rebased. Looks good now. Merging!