Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for choosing between customizer and widgets.php #13858

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Fix logic for choosing between customizer and widgets.php #13858

merged 2 commits into from
Dec 2, 2019

Commits on Nov 28, 2019

  1. Fix logic for choosing customizer or widgets.php 

    This commit changes the logic for determining whether we are in the
customizer or widgets.php. Previously, when accessing widgets from
widgets.php, the logic failed to recognize this when the page
initialized with no widgets.

This change removes the additional check for .widget-control-actions
when initializing the widgets_shell variable. Instead we
make sure the variable is not undefined, and if it is not undefined, we
make sure it is not empty.

This ensures the correct element is selected, even when there are no
initial active plugins.

See #12302 for details.
    @chickenn00dle
    chickenn00dle committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    37d8799 View commit details
    Browse the repository at this point in the history

  2. Bumps version in widget admin setup 

    Bumps version number in widget_admin_setup function to ensure everyone
gets updated file after plugin update.

See #13858 (review)
    @chickenn00dle
    chickenn00dle committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    5a6c21f View commit details
    Browse the repository at this point in the history