Adds tooling for version incrementing

[ChaosExAnima]

Changes proposed in this Pull Request:

• This updates the tooling system to allow automatic version incrementing and sanitization as part of the build step.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

• p9dueE-14S-p2

Testing instructions:

1. Run tools/build-release-branch.sh new
2. Provide normally invalid version, such as 9-beta.
3. When asked, update files.

Expected that version number in branch and in files is as expected.

Proposed changelog entry for your changes:

• N/A

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: December 3, 2019.
Scheduled code freeze: November 26, 2019

Generated by 🚫 dangerJS against dba0242

[kraftbj]

Do we need any verification (e.g. git diff -- "Does this look good? Y to commit".

[ChaosExAnima]

We can totally do that, good idea!

[dereksmart]

This script could be useful for updating the versions on master as well, which is done once per release cycle. What do you think about creating a separate update-version.sh or something that can be use independently from the release branch management (as well as within)?

[ChaosExAnima]

What do you think about creating a separate update-version.sh or something that can be use independently from the release branch management (as well as within)?

Sure! That would definitely simplify logic as well. Would we want to move the git commit logic over as well?

[dereksmart]

move the git commit logic over

Yeah! I'd make the commit optional/reviewable as per Kraft's suggestion to verify.

[jeherve]

I don't have access to -r on my machine:

sed: illegal option -- r
usage: sed script [-Ealn] [-i extension] [file ...]
       sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]

I use macOS's default sed:

❯ which sed
/usr/bin/sed

I suspect I could get this fixed by installing a more recent version via Homebrew, but the same problem could happen to others in the future. Should we require a specific version of sed to run the script and bail early with an error inviting you to install if you don't have the right version? Or can we work around this somehow?

[ChaosExAnima]

I suspect that's because I'm using Ubuntu to develop this. Let me do some digging.

[jeherve]

This doesn't quite work just yet. I get the following errors when testing:

Would you like to update the version number in files to 333.4? [y/N]y
sed: 1: "jetpack.php": invalid command code j
sed: 1: "jetpack.php": invalid command code j
sed: 1: "package.json": extra characters at the end of p command

[kraftbj]

I got it to work be updating the seds to:

sed -E -i '' "s/Version: .+/Version: ${TARGET_VERSION}/" jetpack.php
sed -E -i '' "s/'JETPACK__VERSION',( +)'(.+)'/'JETPACK__VERSION',\1'${TARGET_VERSION}'/" jetpack.php
sed -E -i '' "s/\"version\": \".+\"/\"version\": \"${NPM_TARGET_VERSION}\"/" package.json

It seems like sed on OS X didn't like the whitespace selector for me and -i needed the empty string?

[ChaosExAnima]

@jeherve - Just updated with something that I tested to work with the macOS version of sed. Can you retest, please?

[jeherve]

Now it can edit the version numbers for me.

I am not sure if I did this wrong, but when I provide a version like 555.23, it updates to that number directly. When I provide a version like 555.23-beta, it also updates the version numbers directly but the branch that gets created also uses the -beta suffix, branch-555.23-beta. Ideally it would get removed, don't you think?

[jeherve]

This is working well! I only have one final request: could we also update JETPACK__VERSION when we update version numbers via the script?

[ChaosExAnima]

@jeherve - Okay, resolved. Apparently macOS sed does not like \s, but I tested again and it looks good to me :)

[jeherve]

This seems to work well for me now. It is only failing because of phpcs-changed:

FILE: jetpack.php
-----------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 0 WARNINGS AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
 18 | ERROR | Expected 1 space after comma in argument list; 13 found
-----------------------------------------------------------------------------------------------

This should fix that: #14134

[jeherve]

Rebased to include the fix from the other PR. This should be good to merge now!