Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the [tweet] shortcode AMP handling to Jetpack #14054

Merged
merged 5 commits into from
Nov 19, 2019
Merged

Migrate the [tweet] shortcode AMP handling to Jetpack #14054

merged 5 commits into from
Nov 19, 2019

Commits on Nov 14, 2019

  1. Migrate [tweet] shortcode AMP conversion to AMP 

    This mainly copies the logic in the
AMP plugin into Jetpack.
    @kienstra
    kienstra committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    757ec4b View commit details
    Browse the repository at this point in the history

  2. Add a test case for width=0 

    In that case, the width
should simply be the $default_width.
    @kienstra
    kienstra committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    5dc937d View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2019

  1. Remove extra variable $initial_width 

    There's probably no need to run absint() first,
so simply set the $width.
    @kienstra
    kienstra committed Nov 15, 2019
    Configuration menu
    Copy the full SHA
    c85313f View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2019

  1. Commit Jeremy's suggestion to possibly markTestSkipped() 

    Co-Authored-By: Jeremy Herve <jeremy@tagada.hu>
    @kienstra @jeherve
    kienstra and jeherve authored Nov 19, 2019
    Configuration menu
    Copy the full SHA
    46a25ca View commit details
    Browse the repository at this point in the history

  2. Move the 'wp_footer' hook to an else block 

    As Jeremy mentioned,
this should not run for AMP endpoints.
    @kienstra
    kienstra committed Nov 19, 2019
    Configuration menu
    Copy the full SHA
    37c1df7 View commit details
    Browse the repository at this point in the history