Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check on Marker Popup to be displayed only when block is… #14241

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Add a check on Marker Popup to be displayed only when block is… #14241

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5b022f
Add a check on Marker Popup to be displayed only when block is selected
thrijith Dec 15, 2019
4b0d44f
Extract isSelected from props and use it for checking current block s…
thrijith Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions extensions/blocks/map/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ class MapEdit extends Component {
noticeOperations.createErrorNotice( message );
};
render() {
const { className, setAttributes, attributes, noticeUI, notices } = this.props;
const { className, setAttributes, attributes, noticeUI, notices, isSelected } = this.props;
const {
mapStyle,
mapDetails,
Expand Down Expand Up @@ -266,7 +266,7 @@ class MapEdit extends Component {
onMarkerClick={ () => this.setState( { addPointVisibility: false } ) }
onError={ this.onError }
>
{ addPointVisibility && (
{ isSelected && addPointVisibility && (
<AddPoint
onAddPoint={ this.addPoint }
onClose={ () => this.setState( { addPointVisibility: false } ) }
Expand Down