Fix sharing buttons and like buttons when copying a post

[scottsweb]

Looks like we are explicitly setting sharing_disabled and switch_like_status meta despite the original post relying on the global setting for these to show. It is creating some inconsistencies as per: #14117

Fixes #14117

Changes proposed in this Pull Request:

• This PR attempts to better handle missing meta values on the post being copied

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Bug fix

Testing instructions:

From the issue:

• Make sure the Copy Post module in Jetpack is activated, and that the Classic Editor plugin is not active.
• At WP-Admin ->Posts, make sure you have a post with sharing and Like buttons enabled, and check the buttons are visible in the published post on the front end
• Use the Copy Post feature to create a new post
• Before publishing, check the Jetpack sidebar and make sure sharing and Like buttons are enabled
• Publish the copied post
• Verify if the sharing and like buttons respect those of the original post and are output on the front end

Note: Even if wp-admin is showing the correct values for these toggles, we have been seeing different results in the theme on the front end, so check both places.

Digging deeper. The meta data before the fix is applied:

Original post:

Copied post:

The meta data after the fix is applied:

Original post:

Copied post:

Ideally switch_like_status would not have been set at all in this scenario - but it does seem to work. I think we might need something better than the isset check.

Proposed changelog entry for your changes:

• Bug fix: Ensure correct sharing and like settings are copied when posts are duplicated

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello scottsweb! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D37227-code before merging this PR. Thank you!

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 14, 2020.
Scheduled code freeze: January 7, 2020

Generated by 🚫 dangerJS against 93eed8c

[matticbot]

scottsweb, Your synced wpcom patch D37227-code has been updated.

[scottsweb]

I just pushed a fix, thanks for your suggestion @kraftbj - it looks to have worked.

Before:

After:

So I think the original issue can be marked as resolved.

I do however have a lingering concern, when the settings for sharing and likes are set to 'on' for all new posts and pages, I went into a specific post and turned them off. This gave me the following meta:

It is a shame that sharing_disabled and switch_like_meta are the inverse of each other (both 0 an 1 meaning the option is turned off). It does work as expected though.

When copying in this state though, the meta on the copied post is very different:

sharing_disabled becomes a serialised value, which also seems like a possible bug.

		$sharing = get_post_meta( $source_post->ID, 'sharing_disabled', false );

Should probably become:

		$sharing = get_post_meta( $source_post->ID, 'sharing_disabled', true );

and then we can perform the same check for sharing '' !== $sharing

Do you see that having any other negative impacts?

[jeherve]

sharing_disabled becomes a serialised value, which also seems like a possible bug.

It does indeed seem like a bug, and I like your suggestion for a fix.

[matticbot]

scottsweb, Your synced wpcom patch D37227-code has been updated.

[scottsweb]

@jeherve fix has been pushed:

Original:

Copy:

Values stay as boolean.

[jeherve]

This seems to work well in my tests. Should be good to merge.

Changes were made based on feedback.

[scottsweb]

r201430-wpcom