Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contact form: Use the correct attributes on the Button #14569

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Contact form: Use the correct attributes on the Button #14569

merged 1 commit into from
Feb 10, 2020

Conversation

scruffian
Copy link
Member

This was raised here: #14371 (comment)

Changes proposed in this Pull Request:

  • This uses the same attributes to style the button as the other buttons, so its inline with the rest of the blocks.

Testing instructions:

  • Add a contact form block
  • Check that the button looks like this:

Screenshot 2020-02-04 at 10 48 18

Proposed changelog entry for your changes:

  • no changelog

@scruffian scruffian added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Feb 4, 2020
@scruffian scruffian requested review from davemart-in and a team February 4, 2020 18:49
@scruffian scruffian self-assigned this Feb 4, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello scruffian! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D38510-code before merging this PR. Thank you!

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: February 11, 2020.
Scheduled code freeze: February 4, 2020

Generated by 🚫 dangerJS against 2cc40db

davemart-in
davemart-in approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@davemart-in davemart-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeherve jeherve added this to the 8.3 milestone Feb 10, 2020
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Contact Form [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Feb 10, 2020
@scruffian scruffian merged commit ca039e9 into master Feb 10, 2020
@scruffian scruffian deleted the update/contact-form-button branch February 10, 2020 11:57
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 10, 2020
@scruffian
Copy link
Member Author

rD38510-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davemart-in davemart-in davemart-in approved these changes

@jeherve jeherve jeherve approved these changes

Assignees

@scruffian scruffian

Labels
[Feature] Contact Form [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
8.3
Development

Successfully merging this pull request may close these issues.
5 participants
@scruffian @matticbot @jetpackbot @jeherve @davemart-in