Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: Switch new Whatsapp block to production #16318

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Blocks: Switch new Whatsapp block to production #16318

merged 1 commit into from
Jun 29, 2020

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jun 29, 2020

Changes proposed in this Pull Request:

  • Let's move this block to production since it will go out with Jetpack 8.7

Related PR: #15050

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • With Jetpack Beta blocks disabled, go to Posts > Add New and search for the Send a Message block.
  • Do you see it? 🎉

Proposed changelog entry for your changes:

  • N/A

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] BLOCKER [Block] Send a message labels Jun 29, 2020
@jeherve jeherve added this to the 8.7 milestone Jun 29, 2020
@jeherve jeherve self-assigned this Jun 29, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D45651-code before merging this PR. Thank you!
This revision will be updated with each commit to this PR

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jun 29, 2020
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16318

Scheduled Jetpack release: July 7, 2020.
Scheduled code freeze: June 30, 2020

Generated by 🚫 dangerJS against 6c5126e

@jeherve jeherve merged commit 712a9a0 into master Jun 29, 2020
@jeherve jeherve deleted the switch/whatsapp-production branch June 29, 2020 17:24
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jun 29, 2020
@jeherve
Copy link
Member Author

jeherve commented Jul 7, 2020

r210109-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

Assignees

@jeherve jeherve

Labels
[Block] Send a message [Pri] BLOCKER Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
8.7
Development

Successfully merging this pull request may close these issues.
4 participants
@jeherve @matticbot @jetpackbot @kraftbj