-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation notices: add details about file/function removals #16444
Conversation
In #16433, we determined that we would remove deprecated files and functions 6 months after they've been deprecated. Let's communicate this to site owners as well, by outputting additional details in the error logs when a deprecation notice is issued.
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for the great PR description! When this PR is ready for review, please apply the E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16444 Scheduled Jetpack release: August 4, 2020. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this. Some questions and a couple of suggestions.
Thanks for the feedback. I believe I've addressed everything, it should be ready for another round. |
r210265-wpcom |
Changes proposed in this Pull Request:
In #16433, we determined that we would remove deprecated files and functions 6 months after they've been deprecated.
Let's communicate this to site owners as well, by outputting additional details in the error logs when a deprecation notice is issued.
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Proposed changelog entry for your changes: