-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin Page: switch to @wordpress/date in Stats dashboard #17343
Conversation
Follow-up to #17321 This should allow for better translations and date formatting in i18n languages for all date labels in the Stats graph of the Jetpack dashboard.
Scheduled Jetpack release: November 3, 2020. E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17343 Thank you for the great PR description! When this PR is ready for review, please apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well for me! I tested with a few different languages, and they worked well.
I left an in-line suggestion about a comma in longMonthYearFormat
. It's not a blocker, so if you disagree with my suggestion, feel free to merge.
Co-authored-by: Kim Brown <50059399+kbrown9@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well for me!
Follow-up to #17321
Changes proposed in this Pull Request:
Before (note the untranslated dates and months)
After
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
You'll need an active site with some stats to be able to test things.
Proposed changelog entry for your changes: