Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pay with PayPal: Fix currencies lib loading #17625

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Oct 27, 2020

Changes proposed in this Pull Request:

In #17381 I moved the new Jetpack_Currencies class from the root of Jetpack to _inc/lib but forgot to load it correctly using jetpack_require_lib when rendering a simple-payment shortcode. This PR ensures the lib is loaded as expected.

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Spin a JN site running this branch.
  • Set up Jetpack and purchase any paid plan.
  • Go to WP Admin > Posts > Add new.
  • Insert a Pay with PayPal block and fill it with data.
  • Switch to the code editor in order to grab the ID of the internal simple-payment object created.

Screen Shot 2020-10-27 at 12 55 32

  • Switch back to the visual editor and insert a Shortcode block.
  • Enter [simple-payment id=<ID>].

Screen Shot 2020-10-27 at 13 07 32

  • Publish the post.
  • Make sure the post is published successfully.
  • Visit the published post.
  • Make sure the shortcode is rendered successfully.

Proposed changelog entry for your changes:

N/A.

@mmtr mmtr added [Status] Needs Review To request a review from Crew. Label will be renamed soon. Pay with Paypal labels Oct 27, 2020
@mmtr mmtr requested a review from a team October 27, 2020 12:09
@mmtr mmtr self-assigned this Oct 27, 2020
@jetpackbot
Copy link

Scheduled Jetpack release: November 10, 2020.
Scheduled code freeze: November 3, 2020

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17625

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against ad14ad3

@jeherve jeherve added this to the 9.1 milestone Oct 27, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Oct 27, 2020
@jeherve jeherve merged commit da783cc into master Oct 27, 2020
@jeherve jeherve deleted the fix/pay-with-paypal-require-lib branch October 27, 2020 13:02
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 27, 2020
@jeherve jeherve added the [Block] Pay With Paypal aka Simple Payments label Feb 12, 2021
@jeherve jeherve added the [Feature] Pay with PayPal aka Simple Payments label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants