-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wordpress/eslint-plugin #18624
Conversation
Scheduled Jetpack release: February 16, 2021. Thank you for the great PR description! When this PR is ready for review, please apply the |
There are some other |
The two |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems straightforward enough and CI was happy, let's try it.
But it looks like it needs another master merge.
135a251
to
336d2cf
Compare
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 If you are an automattician, once your PR is ready for review add the "[Status] Needs Team review" label and ask someone from your team review the code. jetpack plugin:
|
Caution: This PR has changes that must be merged to WordPress.com |
I'll close this PR for now because of the lack of activity on this. We can always reopen in the future if needed, but it will need a rebase, so it may be easier to start a new PR at this point. |
See #16763 (comment)
Updates the eslint-plugin package specifically.
Fixes a couple of unrelated test errors from
yarn lint-required
.Changes proposed in this Pull Request:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
n/a
Testing instructions:
yarn lint-required
and see various unsafe api usages in blocks.Proposed changelog entry for your changes: