-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make carousel more robust against missing data #20101
Make carousel more robust against missing data #20101
Conversation
The carousel currently fails if some crucial data properties are missing in the images it attempts to load. This will make it more robust, allowing it to fall back to other ones. In addition, it restores the pointer cursor in some situations. Fixes #11191.
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
…ore-robust-against-missing-properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to test well for me. 🚢
Thank you for the review, @jeherve! 👍 |
Great news! One last step: head over to your WordPress.com diff, D62990-code, and commit it. Thank you! |
r227547-wpcom |
The carousel currently fails if some crucial data properties are missing in the images it attempts to load. This will make it more robust, allowing it to fall back to other ones.
Note that the experience still won't be perfect, as the images will be opened with their gallery sizes (which are likely too small for the carousel), but unfortunately the carousel has no way of knowing the original, larger image size if the properties are missing.
This PR also restores the pointer cursor in some situations.
Fixes #11191.
Changes proposed in this Pull Request:
Jetpack product discussion
None. Related to a bug in this repo, however: #11191
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
originalDimensions
function #11191 (comment) and ensure the carousel works correctly. Note that these sites are on wpcom, so adjust your testing procedure accordingly.