Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Testspace integration #21485

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Remove Testspace integration #21485

merged 1 commit into from
Oct 21, 2021

Conversation

adimoldovan
Copy link
Member

Changes proposed in this Pull Request:

Remove Testspace integration.

Jetpack product discussion

https://app.asana.com/0/1156386383419466/1200494113104454

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • CI green

@adimoldovan adimoldovan self-assigned this Oct 21, 2021
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Oct 21, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Oct 21, 2021
@adimoldovan adimoldovan added [Status] In Progress and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Oct 21, 2021
@adimoldovan adimoldovan marked this pull request as ready for review October 21, 2021 10:25
@adimoldovan adimoldovan added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Oct 21, 2021
@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Oct 21, 2021
@adimoldovan adimoldovan merged commit bb73926 into master Oct 21, 2021
@adimoldovan adimoldovan deleted the e2e/remove-testspace branch October 21, 2021 13:26
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 21, 2021
@anomiex anomiex mentioned this pull request Oct 21, 2021
Merged
davidlonjon added a commit that referenced this pull request Oct 21, 2021
@davidlonjon
Merge branch 'master' into add/boost-e2e-ci-integration
66f75b8 
* master:
  Update the Identity-Crisis readme file. (#21390)
  Remove Testspace integration (#21485)
  tools: Update dependency update tooling (#21462)
  Repo: auto-assign the RNA label to PRs. (#21479)
  RePublicize: add Share Post button (#21377)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

@brbrr brbrr Awaiting requested review from brbrr

Assignees

@adimoldovan adimoldovan

Labels
Actions GitHub actions used to automate some of the work around releases and repository management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adimoldovan @kraftbj