-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS Components: fix weird spinner visual issue #24206
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
540731f
to
967cdbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well for me.
The spinner has the right shape with Gutenberg disabled
The new spinner shows up with latest Gutenberg enabled
Great news! One last step: head over to your WordPress.com diff, D79872-code, and deploy it. Thank you! |
r244781-wpcom |
This PR fixes a visual issue in the Spinner components that happen for WordPress version < 6.0. Basically. The new spinner design from WordPress/gutenberg#37551 will be in WP 6.0 but isn't in 5.9 (thanks to @anomiex)
Fixes JS Components: fix weird spinner visual issue for WordPress < 6.0
Changes proposed in this Pull Request:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: