Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Components: fix weird spinner visual issue #24206

Merged
merged 2 commits into from
May 2, 2022

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented May 2, 2022

This PR fixes a visual issue in the Spinner components that happen for WordPress version < 6.0. Basically. The new spinner design from WordPress/gutenberg#37551 will be in WP 6.0 but isn't in 5.9 (thanks to @anomiex)

Fixes JS Components: fix weird spinner visual issue for WordPress < 6.0

Changes proposed in this Pull Request:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to Protect plugin
  • Disconnect the site
  • Testi with WP < 6.0
before after
image image

@retrofox retrofox added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Size] S RNA [JS Package] Components labels May 2, 2022
@retrofox retrofox requested a review from a team May 2, 2022 13:25
@retrofox retrofox self-assigned this May 2, 2022
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello retrofox! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D79872-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@retrofox retrofox force-pushed the update/js-components-spinner branch from 540731f to 967cdbe Compare May 2, 2022 14:00
Copy link
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me.

The spinner has the right shape with Gutenberg disabled

The new spinner shows up with latest Gutenberg enabled

@retrofox retrofox merged commit 771f2df into master May 2, 2022
@retrofox retrofox deleted the update/js-components-spinner branch May 2, 2022 19:22
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label May 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

Great news! One last step: head over to your WordPress.com diff, D79872-code, and deploy it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@retrofox
Copy link
Contributor Author

retrofox commented May 2, 2022

One last step: head over to your WordPress.com diff, D79872-code, and deploy it.

r244781-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants