Revise Jetpack connection agreement text to comply with our User Agreement

[vikneshwar]

Fixes # 1202858161751496-as-1203651563192009/f

Proposed changes:

• Update the connection agreement text for all plugins to show above the button to comply with the guidelines PCYsg-9m2-p2

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1HpG7-_kep-p2

Does this pull request change what data or activity we track or use?

Testing instructions:

• Spin up a test site
• Jetpack Plugin
  • Build Jetpack plugin by running jetpack build plugins/jetpack
  • Install and Navigate to the Jetpack page (wp-admin/admin.php?page=jetpack#/)
  • Confirm that Terms and condition text is displayed above the button
  • 
• Jetpack ValutPress Backup plugin
  • Build Jetpack Backup plugin by running jetpack build plugins/backup
  • Install and Navigate to Jetpack Backup page (wp-admin/admin.php?page=jetpack-backup)
  • Confirm that Terms and condition text is displayed above the button
  • 
• Jetpack Boost Plugin
  • Build Jetpack Boost plugin by running jetpack build plugins/boost
  • Install and Navigate to Jetpack Boost page (wp-admin/admin.php?page=jetpack-boost)
  • Confirm that Terms and condition text is displayed above the button
  • 
• Jetpack Social Plugin
  • Build Jetpack Boost plugin by running jetpack build plugins/social
  • Install and Navigate to Jetpack Boost page (wp-admin/admin.php?page=jetpack-social)
  • Confirm that Terms and condition text is displayed above the button
  • 
• My Jetpack - Connect your site screen

  • Build Jetpack plugin by running jetpack build plugins/jetpack

  • Install and Navigate to the My Jetpack page (wp-admin/admin.php?page=my-jetpack) and ensure you still haven't connected your site.

  • You will see the message as below and click on the button

  • 

  • On the connection screen confirm that Terms and condition text is displayed above the button

  • 

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1203651563192009

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ⚠️ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

---

Jetpack plugin:

• Next scheduled release: March 7, 2023.
• Scheduled code freeze: February 28, 2023.

---

Backup plugin:

• Next scheduled release: March 7, 2023.
• Scheduled code freeze: February 28, 2023.

---

Boost plugin:

• Next scheduled release: March 7, 2023.
• Scheduled code freeze: February 27, 2023.

---

Social plugin:

• Next scheduled release: March 7, 2023.
• Scheduled code freeze: February 28, 2023.

---

Videopress plugin:

• Next scheduled release: March 7, 2023.
• Scheduled code freeze: February 27, 2023.

[github-actions]

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack update/toc-text-location

to get started. More details: p9dueE-5Nn-p2

[jkguidaven]

I tested the PR via a JN site, and it works as advertised 👍 . I only have one comment.

[jkguidaven]

There also appears to be a problem with the social e2e testing and JS tests. Can you confirm it is not related to the changes?

[mattgawarecki]

I noticed a few failing JS unit tests, so I spent time today to address those. Next up are the end-to-end tests for Social and Boost; I'll report back here with what I find.

[mattgawarecki]

^ Replying to my earlier message: Boost tests were fine (i.e, I was mistaken); Social needed a small update to the connection test so that the correct 'Get Started'element was clicked. Previously only one element on the page had the text "Get Started"; but with our new terms of service notice, there's both a strong and a button. In this case, of course, we need the button.

[mattgawarecki]

Looks like we also had a failing unit test related to some link text. I went ahead and fixed that as well.

[sergeymitr]

Thanks @mattgawarecki, I'll give it a final review first thing in the morning.

[sergeymitr]

Looks great, thanks for working on this!

I also tested on WoA.
There isn't much to test really, as you can't disconnect there, but it doesn't seem to bring any issues either.