-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page navigation for the new feedback dashboard #28826
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run
to get started. More details: p9dueE-5Nn-p2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! A bit annoying that paging block changes width, but nothing we should be concerned at this point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works!
import { useCallback } from '@wordpress/element'; | ||
import { __ } from '@wordpress/i18n'; | ||
import { filter, flatten, map, range } from 'lodash'; | ||
import Gridicon from '../Gridicon'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we pull from the Jetpack component (@automattic/jetpack-components
) instead of adding this copy here?
class Gridicon extends Component< GridiconProps > { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can, I'll make the change. Main reason I did it was I noticed a bunch of packages duplicating this component, which also makes me wonder if there's any edge cases related to that? Regardless of the use case here.
…8826) Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Proposed changes:
This patch implements the page navigation component for the new feedback dashboard, building on top of #28791.
As we still haven't decided on the URL structure for the new app, nor do we have routing support, the
<PageNavigation />
component reports the current selection by calling the providedonSelectPage
function.The component also has an
expandedRange
attribute which allows to control the range of the 'expanded' bit in the middle. I currently set it to2
which works for all screen sizes, but we could come back to it later and make it switch depending on the current screen size, to include a little more when possible.Note: This PR includes changes from the other PR mentioned above that hasn't been merged yet. The new commits start from
644f612
.Other information:
Jetpack product discussion
pcsBup-Pl-p2
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Enable the new feedback dashboard with these filters:
/wp-admin/admin.php?page=jetpack-forms
.Note the page navigation doesn't affect any content yet as we're not yet connected to the backend.