Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests: update edit site button selector #28862

Merged
merged 2 commits into from
Feb 9, 2023

Conversation

adimoldovan
Copy link
Member

@adimoldovan adimoldovan commented Feb 9, 2023

Proposed changes:

Update sector for edit button in broken site editor flow. We were using the button's aria label removed by Gutenberg with WordPress/gutenberg#47343

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1675896045693039-slack-C03QNBQKG73

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Subscribe block test passes with latest Gutenberg

@github-actions github-actions bot added [Status] In Progress Actions GitHub actions used to automate some of the work around releases and repository management E2E Tests labels Feb 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@adimoldovan adimoldovan self-assigned this Feb 9, 2023
@adimoldovan adimoldovan marked this pull request as ready for review February 9, 2023 10:02
@adimoldovan adimoldovan enabled auto-merge (squash) February 9, 2023 10:08
@adimoldovan adimoldovan added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Feb 9, 2023
@adimoldovan adimoldovan requested review from a team and removed request for a-danae February 9, 2023 10:09
@adimoldovan adimoldovan merged commit 89ce810 into trunk Feb 9, 2023
@adimoldovan adimoldovan deleted the e2e/fix-selector-for-edit-button branch February 9, 2023 10:14
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions GitHub actions used to automate some of the work around releases and repository management E2E Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants