Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Odyssey: Remove Calypso recommendations from legacy stats page #29115

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Odyssey: Remove Calypso recommendations from legacy stats page #29115

merged 3 commits into from
Feb 27, 2023

Conversation

a8ck3n
Copy link
Contributor

@a8ck3n a8ck3n commented Feb 23, 2023

Fixes #29112.

Proposed changes:

Now that Odyssey Stats is shipping and we have an upgrade notice in place, we should favour that over pushing people to Calypso. This PR removes the two prompts that link out to WordPress.com.

Previous Behaviour:

LegacyLoadBefore.mp4

Updated Behaviour:

LegacyLoadAfter.mp4

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Make sure Odyssey Stats are disabled.
  • Visit Jetpack → Stats.
  • Confirm the prompt during loading is no longer visible.
  • Confirm the prompt after loading is no longer visible.

@a8ck3n
Odyssey: Remove Calypso nudge.
4f84446 
Doesn’t make sense to push to Calypso now that Odyssey is an option.
@a8ck3n
Odyssey: Remove Calypso nudge (2).
46e158a 
This time from the loading UI.
@a8ck3n
Changelog++
51d9b8b
@a8ck3n a8ck3n self-assigned this Feb 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023 •
edited
Loading

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack update/stats-29112-remove-calypso-nudges

to get started. More details: p9dueE-5Nn-p2

@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Feb 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: March 7, 2023.
  • Scheduled code freeze: February 28, 2023.

@a8ck3n a8ck3n added [Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. Jetpack [Package] Stats Data and removed [Status] In Progress [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Jetpack labels Feb 23, 2023
@a8ck3n a8ck3n requested review from a team and kangzj February 23, 2023 09:28
@a8ck3n a8ck3n marked this pull request as ready for review February 23, 2023 09:28
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress labels Feb 23, 2023
@a8ck3n a8ck3n added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Needs Team Review and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] In Progress labels Feb 23, 2023
kangzj
kangzj approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@kangzj kangzj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good idea to hide these messages since we've got Odyssey now.

It works well and looks good 👍

Another approach to remove the show me button might be changing the WPCOM API, however that'll be a bit risky as we don't know how the other places are using it, so I think the PR is reasonable.

The Opt-in notice still works well by the way.

@kangzj kangzj added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Team Review labels Feb 23, 2023
@samiff samiff self-requested a review February 27, 2023 17:29
@samiff samiff added this to the jetpack/11.9 milestone Feb 27, 2023
samiff
samiff approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@samiff samiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :shipit:

@samiff samiff removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Feb 27, 2023
@samiff samiff added the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 27, 2023
@samiff samiff merged commit 54c781b into trunk Feb 27, 2023
@samiff samiff deleted the update/stats-29112-remove-calypso-nudges branch February 27, 2023 18:10
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 27, 2023
donnchawp pushed a commit that referenced this pull request Mar 1, 2023
@a8ck3n @donnchawp
[not verified] Odyssey: Remove Calypso recommendations from legacy st…
a03235f 
…ats page (#29115)

* Odyssey: Remove Calypso nudge.

Doesn’t make sense to push to Calypso now that Odyssey is an option.

* Odyssey: Remove Calypso nudge (2).

This time from the loading UI.

* Changelog++
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samiff samiff samiff approved these changes

@kangzj kangzj kangzj approved these changes

Assignees

@a8ck3n a8ck3n

Labels
[Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Package] Stats Data [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Milestone
jetpack/11.9
Development

Successfully merging this pull request may close these issues.

Legacy Stats: Remove Calypso recommendation
3 participants
@a8ck3n @kangzj @samiff