Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetpack-mu-wpcom: fix undefined is_plugin_active fatal on wpcom #29158

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

samiff
Copy link
Contributor

@samiff samiff commented Feb 24, 2023

Proposed changes:

Fix the following fatal on wpcom that surfaced from #28932

PHP Fatal error:  Uncaught Error: Call to undefined function Automattic\Jetpack\is_plugin_active() in ...jetpack-mu-wpcom-plugin/production/vendor/automattic/jetpack-mu-wpcom/src/class-jetpack-mu-wpcom.php:52

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Internal: p1677262859532259/1677260163.446909-slack-CBG1CP4EN

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Test the newly built mu-wpcom-plugin on your sandbox and make sure there is no fatal:

bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/mu-wpcom-is-plugin-active

@samiff samiff added [Type] Bug When a feature is broken and / or not performing as intended [Pri] Normal [Package] Jetpack mu wpcom WordPress.com Features labels Feb 24, 2023
@samiff samiff self-assigned this Feb 24, 2023
@samiff samiff added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Feb 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/mu-wpcom-is-plugin-active

to get started. More details: p9dueE-5Nn-p2

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@samiff samiff enabled auto-merge (squash) February 24, 2023 19:08
@samiff samiff added this to the jetpack/11.9 milestone Feb 24, 2023
@samiff samiff requested review from zinigor and anomiex February 24, 2023 20:39
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible.

@samiff samiff merged commit 5bceb98 into trunk Feb 27, 2023
@samiff samiff deleted the fix/mu-wpcom-is-plugin-active branch February 27, 2023 17:00
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Jetpack mu wpcom WordPress.com Features [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants