Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Jetpack Forms dashboard use the "Feedback" menu item in WP Admin #29198

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

ice9js
Copy link
Member

@ice9js ice9js commented Feb 28, 2023

Proposed changes:

This patch updates the WP Admin sidebar configuration so the JP Forms dashboard replaces the existing "Feedback" entry.
At the same time, the old feedback admin page can still be accessed under /wp-admin/edit.php?post_type=feedback, which is intentional until we've reached full feature parity and the old interface can be deprecated.

In the short-term, we'll likely add a link or possibly a user meta setting allowing users to choose what interface they prefer to interact with. It'll be a separate PR as we're still figuring that out.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pcsBup-Pl-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

Enable the new dashboard with these filters:

add_filter( 'jetpack_contact_form_use_package', '__return_true' );
add_filter( 'jetpack_forms_dashboard_enable', '__return_true' );
  • Verify that when the dashboard is enabled, the "Feedback" top-level sidebar item links to the new dashboard and not the default WP Admin interface for feedback.
  • The default feedback admin should still be available when accessing the URL manually: /wp-admin/edit.php?post_type=feedback.

@ice9js ice9js self-assigned this Feb 28, 2023
@github-actions github-actions bot added [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Feb 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack add/jetpack-forms-dashboard-toggle

to get started. More details: p9dueE-5Nn-p2

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: March 7, 2023.
  • Scheduled code freeze: February 28, 2023.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Team Review labels Feb 28, 2023
@ice9js ice9js merged commit 7052646 into trunk Feb 28, 2023
@ice9js ice9js deleted the add/jetpack-forms-dashboard-toggle branch February 28, 2023 10:08
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 28, 2023
@github-actions github-actions bot added this to the jetpack/11.9 milestone Feb 28, 2023
donnchawp pushed a commit that referenced this pull request Mar 1, 2023
…tem in WP Admin (#29198)

* Update the forms dashboard to use the same feedback menu item

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants