Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: remove custom spinner styles #30494

Merged
merged 3 commits into from
May 11, 2023
Merged

Blocks: remove custom spinner styles #30494

merged 3 commits into from
May 11, 2023

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented May 8, 2023

Proposed changes:

This should ensure that the Spinner doesn't conflict with other spinners in the editor.

It was added in ed5175d, as part of #16302, but removing it doesn't seem to break the spinner's look.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

References:

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Check out this branch
  • Go to Posts > Add New
  • Add a Story block
  • As you interact with the block, check that the loading spinner that appears is displayed properly.
  • It should look good on the frontend as well

Here is an example post:
https://crucial-fennec.jurassic.ninja/2023/05/08/a-story/

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] In Progress [Pri] Normal [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels May 8, 2023
@jeherve jeherve self-assigned this May 8, 2023
@github-actions github-actions bot added [Block] Story [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels May 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: June 6, 2023.
  • Scheduled code freeze: May 29, 2023.

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack update/spinner-styles

to get started. More details: p9dueE-5Nn-p2

@jeherve jeherve changed the title Blocks: update spinner styles to match Gutenberg Blocks: remove custom spinner styles May 8, 2023
@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels May 8, 2023
@samiff samiff self-requested a review May 10, 2023 16:18
@samiff samiff added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels May 10, 2023
@samiff samiff added this to the Jetpack/12.2 milestone May 10, 2023
@jeherve jeherve enabled auto-merge (squash) May 11, 2023 08:56
@jeherve jeherve merged commit cce719d into trunk May 11, 2023
@jeherve jeherve deleted the update/spinner-styles branch May 11, 2023 09:02
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Story [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants