Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boost/update readme #31065

Merged
merged 3 commits into from
May 31, 2023
Merged

Boost/update readme #31065

merged 3 commits into from
May 31, 2023

Conversation

thingalon
Copy link
Member

Update READMe for boost

Proposed changes:

  • Update readme
  • Update screenshots

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Look at the changes.

@thingalon thingalon requested review from mikestottuk and a team May 30, 2023 09:25
@thingalon thingalon self-assigned this May 30, 2023
@github-actions github-actions bot added the [Plugin] Boost A feature to speed up the site and improve performance. label May 30, 2023
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Boost plugin:

  • Next scheduled release: June 6, 2023.
  • Scheduled code freeze: May 29, 2023.

mikestottuk
mikestottuk approved these changes May 30, 2023
View reviewed changes
projects/plugins/boost/readme.txt Outdated

Read more about minifying files at [web.dev](https://web.dev/minify-css/)

Google PageSpeed API is used to measure the performance score of a site. It's important to look at the Page Speed score because Core Web Vitals are going to be used as a ranking factor in search engines which means improving your SERP listing and increase your website visitors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use our own now, don't we? So probably need to update this bit

@mikestottuk
Copy link
Contributor

LGTM - screenshots will need to be SVN'd up - they're not in the mirror repo.

@thingalon thingalon merged commit ea3a944 into trunk May 31, 2023
@thingalon thingalon deleted the boost/update-readme branch May 31, 2023 02:25
thingalon added a commit that referenced this pull request May 31, 2023
@thingalon
Boost/update readme (#31065)
abb098f 
* Update screenshots and readme

* changelog

* Remove out-dated paragraph

---------

Co-authored-by: Mark George <thingalon@gmail.com>
haqadn added a commit that referenced this pull request Jun 1, 2023
@haqadn @thingalon @dilirity
Prepare for next release (#31107)
6cfe563 
* Update readme and changelogs for Boost 1.9.0-beta

* Updated package versions for automattic/jetpack-boost

* [not verified] Boost/add minify to pricing (#30711)

* Add minify and concat to pricing tables

* changelog

---------

Co-authored-by: Mark George <thingalon@gmail.com>

* [not verified] Boost: Fix UI issues (#30751)

* Fix showing exclude text when no value is empty

* Fix bottom tooltip showing below footer on getting started page

* Update tooltip position in pricing table component to be configurable

* Update tooltip positions in left column on getting started page

* Fix score text capitalization

* Add changelogs

* [not verified] Boost: Update Minify to use old Page Optimize file functions (#30829)

* Fix concat initializing despite file system being unavailable

* add changelog

* Ignore file_* function usage for phpcs

* Update changelog

* Revert changes to minify setup helper

* [not verified] Boost: Fix Minify concat not working when WP is running from a subdirectory on the server (#30863)

* Fix issues with wp instances in subdirectory urls

* Add changelog

* Boost: Make Minify concat concat service independent of WordPress (#30825)

* Attempt to remove WordPress dependencies from Minify service

* add changelog

* Fix concat initializing despite file system being unavailable

* add changelog

* Add missing cssmin library

* Ignore file_* function usage for phpcs

* Update changelog

* Revert changes to minify setup helper

* Attempt to remove WordPress dependencies from Minify service

* Add changelog

* Add missing cssmin library

* Clean up old file system references

* Fix issues with wp instances in subdirectory urls

* Fix issues with wp instances in subdirectory urls

* Add changelog

* Remove comments

* Improve code readability

* Make linter happy

* changelog

---------

Co-authored-by: Mark George <thingalon@gmail.com>

* [not verified] [Boost] Fix minify paths on sites in a subdir. (#30893)

* Properly take home_url into account to catch subdir paths

* changelog

* Prepend method with jetpack_boost_

---------

Co-authored-by: Mark George <thingalon@gmail.com>

* [not verified] [Boost] Remove invalid apply_filter on minified CSS (#31058)

* Do not call style_loader_tag with an array of handles

* changelog

---------

Co-authored-by: Mark George <thingalon@gmail.com>

* [not verified] [Boost] Avoid double-prefixing url() values in minified CSS (#31059)

* Prevent double-prefixing subdirectories

* changelog

---------

Co-authored-by: Mark George <thingalon@gmail.com>

* Boost/update readme (#31065)

* Update screenshots and readme

* changelog

* Remove out-dated paragraph

---------

Co-authored-by: Mark George <thingalon@gmail.com>

* Update readme, changelogs

* Update version numbers

* fix changelog link

* [not verified] Updated automattic/jetpack-boost version to 1.9.1

* [not verified] Updated package versions for automattic/jetpack-boost

* [not verified] Update readme and changelog

* Set stable tag to 1.9.0

* Fixup project versions

* Fix changelog and project versions

* Fix boost composer

* Composer update

* Composer update from within docker container for php 8.0

---------

Co-authored-by: thingalon <mark@thingalon.com>
Co-authored-by: Mark George <thingalon@gmail.com>
Co-authored-by: Peter Petrov <peter.petrov89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikestottuk mikestottuk mikestottuk approved these changes

Assignees

@thingalon thingalon

Labels
[Plugin] Boost A feature to speed up the site and improve performance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thingalon @mikestottuk