-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ImageCDN parsing to rely on HTML API instead of RegExps #32700
Merged
Commits on Aug 24, 2024
-
Refactor ImageCDN parsing to rely on HTML API instead of RegExps (#32700
) The introduction of the HTML API into WordPress 6.2 offers a new method of matching and modifying HTML. In this patch we're replacing code that attempts to parse the input HTML and visit all images, then read and modify them based on the values of their attributes and computed Photon properties. In the previous code the `Image_CDN` class scanned the entire HTML document to generate a list of PREG image match objects, then iterated over those matches and performed string-replace operations on them. Now the class does a pass from start to finish, visting each image tag along the way, and making the appropriate modifications. Co-authored-by: Adnan Haque <3737780+haqadn@users.noreply.github.com> Co-authored-by: Brandon Kraft <public@brandonkraft.com> Co-authored-by: Jeremy Herve <jeremy@jeremy.hu> Co-authored-by: Mark George <thingalon@gmail.com> Co-authored-by: Osk <oskosk@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 227be97 - Browse repository at this point
Copy the full SHA 227be97View commit details -
Rearrange semantically equivalent test output to avoid false negatives.
No `assertEquivalentMarkup` exists yet, so this gets around that without creating one.
Configuration menu - View commit details
-
Copy full SHA for c07bf51 - Browse repository at this point
Copy the full SHA c07bf51View commit details
Commits on Aug 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 12c5dc7 - Browse repository at this point
Copy the full SHA 12c5dc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a26095 - Browse repository at this point
Copy the full SHA 9a26095View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd5d285 - Browse repository at this point
Copy the full SHA bd5d285View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc0db1e - Browse repository at this point
Copy the full SHA bc0db1eView commit details
Commits on Aug 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0603fc9 - Browse repository at this point
Copy the full SHA 0603fc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3517e03 - Browse repository at this point
Copy the full SHA 3517e03View commit details
Commits on Aug 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cbd3417 - Browse repository at this point
Copy the full SHA cbd3417View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8986690 - Browse repository at this point
Copy the full SHA 8986690View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.