-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent undefined get_current_screen
function errors
#39228
fix: Prevent undefined get_current_screen
function errors
#39228
Conversation
This function is undefined in certain contexts -- e.g., a REST API request that results in enqueueing assets. Referencing an undefined function results in a fatal error. With the `get_current_screen` function specifically, it is common practice to check the function's existence prior to invoking the it. https://developer.wordpress.org/reference/functions/get_current_screen/#comment-5424
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
👋🏻 @miksansegundo. This is my first time modifying Thank you! 🙇🏻♂️ |
* fix: Prevent undefined `get_current_screen` function errors This function is undefined in certain contexts -- e.g., a REST API request that results in enqueueing assets. Referencing an undefined function results in a fatal error. With the `get_current_screen` function specifically, it is common practice to check the function's existence prior to invoking the it. https://developer.wordpress.org/reference/functions/get_current_screen/#comment-5424 * docs: Add change log entry
Proposed changes:
Guard against invocations of an undefined
get_current_screen
function.This function is undefined in certain contexts -- e.g., a REST API
request that results in enqueueing assets. Referencing an undefined
function results in a fatal error. With the
get_current_screen
function specifically, it is common practice to check the function's
existence prior to invoking the it.
Other information:
Jetpack product discussion
N/A, no product discussion occurred for this bug fix.
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Verify feature stability with testing instructions similar to #38475.
<site_domain>/wp-admin/post-new.php?post_type=page
.