-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSO: remove legacy codebase in favor of code in Connection package #39327
Conversation
Fixes Automattic/vulcan#385 This codebase was deprecated in #37153, it's now time to remove it.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of that 👍
…39327) * SSO: remove legacy codebase in favor of code in Connection package Fixes Automattic/vulcan#385 This codebase was deprecated in #37153, it's now time to remove it. * Remove admin CSS building tooling
Fixes https://github.com/Automattic/vulcan/issues/385
Proposed changes:
This codebase was deprecated in #37153, it's now time to remove it.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
The existing feature should continue to work as expected, and you should not see any deprecation warnings when tailing your error log.